Add all2all initial impl #51
Merged
+1,162
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaroufim
pushed a commit
that referenced
this pull request
Aug 20, 2025
msaroufim
reviewed
Aug 26, 2025
problems/amd/all2all/reference.py
Outdated
| cfg, all_rank_data = data | ||
| world_size = 8 | ||
|
|
||
| mp.set_start_method("spawn", force=True) |
There was a problem hiding this comment.
we were doing this on our end, I'm still unsure whether we should do this or make users do this. It seems "fine" if we can just provide a helper or copy pastable code in template for folks -cc @ngc92
msaroufim
reviewed
Aug 26, 2025
problems/amd/all2all/reference.py
Outdated
| # num experts per rank | ||
| self.num_local_experts = cfg.num_experts // world_size | ||
| # max recv tokens per rank | ||
| self.max_recv = cfg.max_num_tokens * cfg.experts_per_token |
There was a problem hiding this comment.
n00b q is reasonable loading balancing guaranteed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR included reference.py and submission.py and task description
I initially added some shapes which all from popular models like deepseek series, gpt-oss, mixtral. You can check if they work with the reference.py and submission.py on your end.
Thanks