fix: ensure default model is parsed when using default model provider #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
force-pushed
the
default-model-provider-set-model
branch
from
bbd0e2b to
d3f07ad
Compare
thedadams
requested review from
StrongMonkey,
g-linville,
iwilltry42,
njhale and
tylerslaton
njhale
approved these changes
Jul 31, 2024
When using the default model provider flag, the default model will be gpt-4o. However, when it is parsed, the expected format is 'gpt-4p from my-model-provider'. When using a default model provider, the 'gpt-4o' was being parsed and the model was set to the empty string. After this change, if the model name is empty after parsing, then we know that the model from the request doesn't have a 'from' in it and the first part of the split reference should be used. Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
default-model-provider-set-model
branch
from
d3f07ad to
7646c4b
Compare
iwilltry42
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the default model provider flag, the default model will be
gpt-4o. However, when it is parsed, the expected format is 'gpt-4p from
my-model-provider'. When using a default model provider, the 'gpt-4o'
was being parsed and the model was set to the empty string.
After this change, if the model name is empty after parsing, then we
know that the model from the request doesn't have a 'from' in it and the
first part of the split reference should be used.