Skip to content

chore: ignore release time when publishing electron builds #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2024
Merged

chore: ignore release time when publishing electron builds #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
588baee
chore: ignore release time when publishing electron builds
njhale Aug 7, 2024
d3835a9
chore: ensure builds are published to non-draft releases
njhale Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ jobs:
- name: Build Electron app
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
EP_GH_IGNORE_TIME: true
EP_DRAFT: false
APPLE_API_KEY: /tmp/apikey.p8
APPLE_API_KEY_ID: ${{ secrets.ELECTRON_APPLE_API_KEY_ID }}
APPLE_API_ISSUER: ${{ secrets.ELECTRON_APPLE_API_ISSUER }}
Expand Down
6 changes: 5 additions & 1 deletion electron/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,15 @@ function go() {
}
console.log(`targetPlatform: ${targetPlatform}`)

// Only publish when the GH_TOKEN is set.
// This indicates the intent to publish the build to a release.
const publishOption = process.env.GH_TOKEN ? 'always' : 'never';

builder
.build({
targets: Platform[targetPlatform.toUpperCase()].createTarget(),
config: options,
publish: 'always',
publish: publishOption,
})
.then((result) => {
console.info('----------------------------');
Expand Down