Fix: revamp knowledge UX based on feedback #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrongMonkey
force-pushed
the
knowledge-fix
branch
from
f45ea2c to
72f16c9
Compare
StrongMonkey
requested review from
g-linville,
iwilltry42,
njhale,
ryanhopperlowe and
thedadams
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
force-pushed
the
knowledge-fix
branch
from
72f16c9 to
c0ff043
Compare
thedadams
approved these changes
Aug 29, 2024
iwilltry42
approved these changes
Aug 29, 2024
|
Merging this so I can have the latest changes for my work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revamps knowledge UX in assistant page, also added some error handling.
#335