Skip to content

fix: android version now correctly builds as a number #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2022
Merged

fix: android version now correctly builds as a number #1770

merged 3 commits into from
Dec 8, 2022

Conversation

@JaccoGoris
Copy link
Contributor

@JaccoGoris JaccoGoris commented Dec 7, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1767 🦕

@JaccoGoris JaccoGoris requested a review from a team as a code owner December 7, 2022 09:27
@JaccoGoris JaccoGoris requested a review from a team December 7, 2022 09:27
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 7, 2022
@mrzmyr
Copy link

mrzmyr commented Dec 7, 2022

Thanks @JaccoGoris 🔥

@chingor13, what needs to be done before merging?

mrzmyr added a commit to mrzmyr/pixy-mood-tracker-app that referenced this pull request Dec 7, 2022
@mrzmyr
fix: use fixed fork for now until issue is resolved in original repo
46a4260 
ref: googleapis/release-please#1770
chingor13
chingor13 requested changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but the test needs to be fixed

@mrzmyr
Copy link

mrzmyr commented Dec 7, 2022

@JaccoGoris, can you take a look at the test? 🫣

@JaccoGoris
Copy link
Contributor Author

JaccoGoris commented Dec 7, 2022

Didn't see that the snapshot was wrong. I ran the tests but about half of them fail locally with graphql errors, http issues and api rate limits. So I missed my broken test :D

Added a fix, hoping it works this time!

@chingor13 chingor13 merged commit d54483b into googleapis:main Dec 8, 2022
@release-please release-please bot mentioned this pull request Dec 8, 2022
Merged
@mrzmyr mrzmyr mentioned this pull request Dec 8, 2022
Merged
chingor13 pushed a commit to googleapis/release-please-action that referenced this pull request Dec 8, 2022
@mrzmyr
fix: update release-please to 14.17.5 (#671)
4da3bc1 
- googleapis/release-please#1767
- googleapis/release-please#1770
- https://github.com/googleapis/release-please/releases/tag/v14.17.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expo requires Android's versionCode to be a integer (not a string)

3 participants

@JaccoGoris @mrzmyr @chingor13