fix: Add aiohttp conditional type checking #1234
Open
+10
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add aiohttp conditional type checking.
was available, causing NameError when aiohttp wasn't installed
Before the Fix:
This would ALWAYS try to reference aiohttp.ClientResponse
if not isinstance(self.response_stream, (httpx.Response, aiohttp.ClientResponse)):
❌ CRASH: NameError if aiohttp not installed
After the Fix:
Step 1: Build valid types conditionally
valid_types = (httpx.Response,) Always start with httpx
if has_aiohttp:
valid_types = (httpx.Response, aiohttp.ClientResponse) Add aiohttp if available
Step 2: Use the conditional types
if not isinstance(self.response_stream, valid_types):
✅ No crash - only references types that exist
Fixes issue #1230