Skip to content

deps: remove test dependency on pytest-mock package #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
# Packages required for basic development flow.
"dev": [
"pytest",
"pytest-mock",
"pre-commit",
"nox",
"google-cloud-testutils",
Expand Down
29 changes: 15 additions & 14 deletions tests/unit/ml/test_compose.py
Original file line number Diff line number Diff line change
Expand Up @@ -281,26 +281,27 @@ def test_customtransformer_compile_sql(mock_X):
]


def create_bq_model_mock(mocker, transform_columns, feature_columns=None):
def create_bq_model_mock(monkeypatch, transform_columns, feature_columns=None):
properties = {"transformColumns": transform_columns}
mock_bq_model = bigquery.Model("model_project.model_dataset.model_id")
type(mock_bq_model)._properties = mock.PropertyMock(return_value=properties)
if feature_columns:
result = [
bigquery.standard_sql.StandardSqlField(col, None) for col in feature_columns
]
mocker.patch(
"google.cloud.bigquery.model.Model.feature_columns",
new_callable=mock.PropertyMock(return_value=result),
monkeypatch.setattr(
type(mock_bq_model),
"feature_columns",
mock.PropertyMock(return_value=result),
)

return mock_bq_model


@pytest.fixture
def bq_model_good(mocker):
def bq_model_good(monkeypatch):
return create_bq_model_mock(
mocker,
monkeypatch,
[
{
"name": "ident_culmen_length_mm",
Expand Down Expand Up @@ -337,9 +338,9 @@ def bq_model_good(mocker):


@pytest.fixture
def bq_model_merge(mocker):
def bq_model_merge(monkeypatch):
return create_bq_model_mock(
mocker,
monkeypatch,
[
{
"name": "labelencoded_county",
Expand All @@ -357,9 +358,9 @@ def bq_model_merge(mocker):


@pytest.fixture
def bq_model_no_merge(mocker):
def bq_model_no_merge(monkeypatch):
return create_bq_model_mock(
mocker,
monkeypatch,
[
{
"name": "ident_culmen_length_mm",
Expand All @@ -372,9 +373,9 @@ def bq_model_no_merge(mocker):


@pytest.fixture
def bq_model_unknown_ML(mocker):
def bq_model_unknown_ML(monkeypatch):
return create_bq_model_mock(
mocker,
monkeypatch,
[
{
"name": "unknownml_culmen_length_mm",
Expand All @@ -391,9 +392,9 @@ def bq_model_unknown_ML(mocker):


@pytest.fixture
def bq_model_flexnames(mocker):
def bq_model_flexnames(monkeypatch):
return create_bq_model_mock(
mocker,
monkeypatch,
[
{
"name": "Flex Name culmen_length_mm",
Expand Down
11 changes: 6 additions & 5 deletions tests/unit/ml/test_golden_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
from google.cloud import bigquery
import pandas as pd
import pytest
import pytest_mock

import bigframes
from bigframes.ml import core, decomposition, linear_model
import bigframes.ml.core
import bigframes.pandas as bpd

TEMP_MODEL_ID = bigquery.ModelReference.from_string(
Expand Down Expand Up @@ -50,10 +50,11 @@ def mock_session():


@pytest.fixture
def bqml_model_factory(mocker: pytest_mock.MockerFixture):
mocker.patch(
"bigframes.ml.core.BqmlModelFactory._create_model_ref",
return_value=TEMP_MODEL_ID,
def bqml_model_factory(monkeypatch):
monkeypatch.setattr(
bigframes.ml.core.BqmlModelFactory,
"_create_model_ref",
mock.Mock(return_value=TEMP_MODEL_ID),
)
bqml_model_factory = core.BqmlModelFactory()

Expand Down
9 changes: 5 additions & 4 deletions tests/unit/session/test_io_bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import datetime
import re
from typing import Iterable
from unittest import mock

import google.cloud.bigquery as bigquery
import pytest
Expand All @@ -27,10 +28,10 @@


@pytest.fixture(scope="function")
def mock_bq_client(mocker):
mock_client = mocker.Mock(spec=bigquery.Client)
mock_query_job = mocker.Mock(spec=bigquery.QueryJob)
mock_row_iterator = mocker.Mock(spec=bigquery.table.RowIterator)
def mock_bq_client():
mock_client = mock.create_autospec(bigquery.Client)
mock_query_job = mock.create_autospec(bigquery.QueryJob)
mock_row_iterator = mock.create_autospec(bigquery.table.RowIterator)

mock_query_job.result.return_value = mock_row_iterator

Expand Down