Skip to content

chore: add logging for blob operations #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

chore: add logging for blob operations #1543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bigframes/operations/blob.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import requests

from bigframes import clients
from bigframes.core import log_adapter
import bigframes.dataframe
import bigframes.exceptions as bfe
from bigframes.operations import base
Expand All @@ -33,6 +34,7 @@
FILE_EXT_REGEX = r"(\.[0-9a-zA-Z]+$)"


@log_adapter.class_logger
class BlobAccessor(base.SeriesMethods):
def __init__(self, *args, **kwargs):
if not bigframes.options.experiments.blob:
Expand Down
8 changes: 6 additions & 2 deletions bigframes/session/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1757,7 +1757,9 @@ def from_glob_path(

table = self._create_object_table(path, connection)

s = self.read_gbq(table)["uri"].str.to_blob(connection)
s = self._loader.read_gbq_table(table, api_name="from_glob_path")[
"uri"
].str.to_blob(connection)
return s.rename(name).to_frame()

def _create_bq_connection(
Expand Down Expand Up @@ -1807,7 +1809,9 @@ def read_gbq_object_table(
table = self.bqclient.get_table(object_table)
connection = table._properties["externalDataConfiguration"]["connectionId"]

s = self.read_gbq(object_table)["uri"].str.to_blob(connection)
s = self._loader.read_gbq_table(object_table, api_name="read_gbq_object_table")[
"uri"
].str.to_blob(connection)
return s.rename(name).to_frame()


Expand Down