This repository was archived by the owner on Sep 19, 2023. It is now read-only.
chore: split the shared dependencies BOM into two (internally) #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
suztomo
added
the
do not merge
suztomo
commented
Aug 2, 2021
Comment on lines
+86
to
+87
| <groupId>com.google.code.gson</groupId> | ||
| <artifactId>gson</artifactId> |
Member
Author
There was a problem hiding this comment.
Placing gson as third-party library, because the Libraries BOM doesn't have it.
Comment on lines
+106
to
+107
| <groupId>com.google.code.findbugs</groupId> | ||
| <artifactId>jsr305</artifactId> |
Member
Author
There was a problem hiding this comment.
Placing jsr305 as third-party library, because the Libraries BOM doesn't have it.
Comment on lines
+111
to
+112
| <groupId>com.google.errorprone</groupId> | ||
| <artifactId>error_prone_annotations</artifactId> |
Member
Author
There was a problem hiding this comment.
Placing error_prone_annotations as third-party library, because the Libraries BOM doesn't have it.
suztomo
removed
the
do not merge
Member
Author
|
It seems that some values are outdated. |
lesv
reviewed
Aug 24, 2021
| @@ -0,0 +1,192 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Member
Author
There was a problem hiding this comment.
I don't find Yoshi Java repositories declare license and copyright in pom.xml files. I see <organization> and <license> elements, which I think should deliver License & Copyright.
suztomo
commented
Aug 24, 2021
first-party-dependencies/pom.xml
Outdated
Comment on lines
59
to
71
| <grpc.version>1.39.0</grpc.version> | ||
| <gax.version>1.67.0</gax.version> | ||
| <grpc-gcp.version>1.1.0</grpc-gcp.version> | ||
| <guava.version>30.1.1-android</guava.version> | ||
| <protobuf.version>3.17.3</protobuf.version> | ||
| <google.api-common.version>1.10.6</google.api-common.version> | ||
| <google.common-protos.version>2.3.2</google.common-protos.version> | ||
| <google.core.version>1.95.4</google.core.version> | ||
| <google.auth.version>1.0.0</google.auth.version> | ||
| <google.http-client.version>1.39.2</google.http-client.version> | ||
| <google.oauth-client.version>1.31.5</google.oauth-client.version> | ||
| <google.api-client.version>1.32.1</google.api-client.version> | ||
| <iam.version>1.0.14</iam.version> |
Member
Author
There was a problem hiding this comment.
I need to update them to the latest versions.
BenWhitehead
approved these changes
Aug 24, 2021
|
Good refactoring, also we'll need to Change guava to jre from android |
Member
Author
|
Fixed outdated values in the files, including Guava version. |
suztomo
commented
Aug 25, 2021
| <google.oauth-client.version>1.32.1</google.oauth-client.version> | ||
| <google.api-client.version>1.32.1</google.api-client.version> | ||
| <iam.version>1.1.0</iam.version> | ||
| </properties> |
Member
Author
There was a problem hiding this comment.
Values from master (b28723a)
<grpc.version>1.40.0</grpc.version>
<gax.version>2.3.0</gax.version>
<grpc-gcp.version>1.1.0</grpc-gcp.version>
<guava.version>30.1.1-jre</guava.version>
<protobuf.version>3.17.3</protobuf.version>
<google.api-common.version>2.0.1</google.api-common.version>
<google.common-protos.version>2.3.2</google.common-protos.version>
<google.core.version>2.1.1</google.core.version>
<google.auth.version>1.1.0</google.auth.version>
<google.http-client.version>1.39.2</google.http-client.version>
<google.oauth-client.version>1.32.1</google.oauth-client.version>
<google.api-client.version>1.32.1</google.api-client.version>
<gson.version>2.8.8</gson.version>
<threeten.version>1.5.1</threeten.version>
<javax.annotations.version>1.3.2</javax.annotations.version>
<animal-sniffer.version>1.20</animal-sniffer.version>
<iam.version>1.1.0</iam.version>
<opencensus.version>0.28.0</opencensus.version>
<findbugs.version>3.0.2</findbugs.version>
<errorprone.version>2.9.0</errorprone.version>
<jackson.version>2.12.4</jackson.version>
<codec.version>1.15</codec.version>
<httpcomponents.httpcore.version>4.4.14</httpcomponents.httpcore.version>
<httpcomponents.httpclient.version>4.5.13</httpcomponents.httpclient.version>
suztomo
commented
Aug 25, 2021
| <codec.version>1.15</codec.version> | ||
| <httpcomponents.httpcore.version>4.4.14</httpcomponents.httpcore.version> | ||
| <httpcomponents.httpclient.version>4.5.13</httpcomponents.httpclient.version> | ||
| </properties> |
Member
Author
There was a problem hiding this comment.
Values from master (b28723a)
<gson.version>2.8.8</gson.version>
<threeten.version>1.5.1</threeten.version>
<javax.annotations.version>1.3.2</javax.annotations.version>
<animal-sniffer.version>1.20</animal-sniffer.version>
<iam.version>1.1.0</iam.version>
<opencensus.version>0.28.0</opencensus.version>
<findbugs.version>3.0.2</findbugs.version>
<errorprone.version>2.9.0</errorprone.version>
<jackson.version>2.12.4</jackson.version>
<codec.version>1.15</codec.version>
<httpcomponents.httpcore.version>4.4.14</httpcomponents.httpcore.version>
<httpcomponents.httpclient.version>4.5.13</httpcomponents.httpclient.version>
Member
Author
|
@Neenu1995 This pull request adds 2 new artifacts ( |
suztomo
changed the title
Member
Author
|
I'm feeling that I should merge this #445 first to set the version to contain "-SNAPSHOT". |
suztomo
force-pushed
the
split_into_two
branch
from
b33ebce to
3bd28c5
Compare
Member
Author
|
Now the version contains "-SNAPSHOT". |
Neenu1995
approved these changes
Aug 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following libraries are built by Google but not intended for the Libraries BOM. Therefore I put them as third-party BOM: