Run tests for PRs to branches other than master #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Just out of curiosity, if someone submits a PR (that none of us review) that echo's our encrypted keys in plaintext, what's the point of encrypting the keys ? Should we have to approve it before the tests are run by OUR Travis instance? |
|
@jgeewax Right now, we only decrypt the keys in non-PR Travis builds (see here), so I don't think that particular scenario can happen right now. If we happen to change the CI build code, we should be sure to decrypt the keys only when merging in a PR. @mziccard Do you think we should remove the check for whether the branch is the |
|
Cool - so long as we're not opening up a gaping security hole :) |
|
@jgeewax Everything that we encrypt/decrypt needs travis encryption variables that are only available for non-PR builds (AFAIK). So decrypting the keys in a PR should not be possible. @ajkannan I thought to leave integration tests only for master but you are right we should run them (if any) also in other branches. I'll fix this! |
mziccard
force-pushed
the
test-all-branches
branch
from
68f6648 to
1830275
Compare
aozarov
added a commit
that referenced
this pull request
Nov 30, 2015
Run tests for PRs to branches other than master
github-actions bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
…424) * feat: generating GAPIC libraries for Google Cloud Functions v2beta PiperOrigin-RevId: 454900284 Source-Link: googleapis/googleapis@05576c8 Source-Link: https://github.com/googleapis/googleapis-gen/commit/5b2f0e36d27aa58fbde15d1e7ab7138cf5ea837a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWIyZjBlMzZkMjdhYTU4ZmJkZTE1ZDFlN2FiNzEzOGNmNWVhODM3YSJ9 feat: generating GAPIC libraries for Google Cloud Functions v2alpha PiperOrigin-RevId: 454899846 Source-Link: googleapis/googleapis@7088e38 Source-Link: https://github.com/googleapis/googleapis-gen/commit/c3673f892c803b9c3f17841bcdee7db6b3179444 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzM2NzNmODkyYzgwM2I5YzNmMTc4NDFiY2RlZTdkYjZiMzE3OTQ0NCJ9 chore: Integrate new gapic-generator-java and rules_gapic PiperOrigin-RevId: 454027580 Source-Link: googleapis/googleapis@1b22277 Source-Link: https://github.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9 feat: added support for CMEK docs: clarified wording around quota usage Clients can now specify the docker registry to use for storing function Docker images and KMS crypto keys for function source code objects. PiperOrigin-RevId: 453234231 Source-Link: googleapis/googleapis@d180952 Source-Link: https://github.com/googleapis/googleapis-gen/commit/836ff24b7e881ef46acd17836c46ed1a9832b195 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODM2ZmYyNGI3ZTg4MWVmNDZhY2QxNzgzNmM0NmVkMWE5ODMyYjE5NSJ9 chore(deps): upgrade gapic-generator-java to 2.8.0 and update gax-java to 2.18.1 PiperOrigin-RevId: 450543911 Source-Link: googleapis/googleapis@5528344 Source-Link: https://github.com/googleapis/googleapis-gen/commit/9f6775cab1958982b88967a43e5e806af0f135db Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWY2Nzc1Y2FiMTk1ODk4MmI4ODk2N2E0M2U1ZTgwNmFmMGYxMzVkYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Enable REST transport for most of Java and Go clients PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update pom.xml * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: add grpc-google-iam-v1 * chore: remove unused dependency * fix: update gapic-generator-java with mock service generation fixes PiperOrigin-RevId: 457524730 Source-Link: googleapis/googleapis@917e7f2 Source-Link: https://github.com/googleapis/googleapis-gen/commit/2497f9a069d3f6b2d6810d5a4e239cda1e7e5a39 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjQ5N2Y5YTA2OWQzZjZiMmQ2ODEwZDVhNGUyMzljZGExZTdlNWEzOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * remove proto-google-iam-v1 dependency Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Neenu Shaji <[email protected]> Co-authored-by: Neenu1995 <[email protected]> Co-authored-by: Vadym Matsishevskyi <[email protected]>
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [2.4.2](googleapis/java-functions@v2.4.1...v2.4.2) (2022-07-01) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#424](googleapis/java-functions#424)) ([898dfd9](googleapis/java-functions@898dfd9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
* feat: release the Google Analytics Admin API V1 Beta PiperOrigin-RevId: 458479633 Source-Link: googleapis/googleapis@6ef569e Source-Link: https://github.com/googleapis/googleapis-gen/commit/e37591034b71728fcd61acd61b0be0caa7625c9e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTM3NTkxMDM0YjcxNzI4ZmNkNjFhY2Q2MWIwYmUwY2FhNzYyNWM5ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: remove iam dependency * chore: remove unused proto-google-common-protos Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: alicejli <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
…s to v2.1.7 (#424) * chore(deps): update dependency com.google.cloud:google-cloud-workflows to v2.1.7 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
* update package names to match v2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update pom.xml Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
🤖 I have created a release *beep* *boop* --- ## [1.6.2](https://togithub.com/googleapis/java-iam/compare/v1.6.1...v1.6.2) (2022-10-02) ### Documentation * **samples:** Update package names to match v2 ([#424](https://togithub.com/googleapis/java-iam/issues/424)) ([3a4392a](https://togithub.com/googleapis/java-iam/commit/3a4392af5d222d349b2fb8352c041b7889be97b5)) ### Dependencies * Update dependency cachetools to v5 ([#459](https://togithub.com/googleapis/java-iam/issues/459)) ([89ea28b](https://togithub.com/googleapis/java-iam/commit/89ea28b2d57b4bdb11b8d847af313c63c8023146)) * Update dependency certifi to v2022.9.24 ([#440](https://togithub.com/googleapis/java-iam/issues/440)) ([de6c438](https://togithub.com/googleapis/java-iam/commit/de6c438b7709e71bdcc2c1c47702b808f828a42f)) * Update dependency charset-normalizer to v2.1.1 ([#444](https://togithub.com/googleapis/java-iam/issues/444)) ([5715206](https://togithub.com/googleapis/java-iam/commit/57152061f264629aa0f09f2602abf6fe3b242945)) * Update dependency click to v8.1.3 ([#445](https://togithub.com/googleapis/java-iam/issues/445)) ([189a5c4](https://togithub.com/googleapis/java-iam/commit/189a5c4102bd6b9f4fbfc252a67019a7c5e23ee3)) * Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20220911-2.0.0 ([#435](https://togithub.com/googleapis/java-iam/issues/435)) ([5d415a9](https://togithub.com/googleapis/java-iam/commit/5d415a98f4e7cede137b57e048ec70c21ea8376d)) * Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20220925-2.0.0 ([#439](https://togithub.com/googleapis/java-iam/issues/439)) ([b17765b](https://togithub.com/googleapis/java-iam/commit/b17765b5e897bcef60aeef56ed2524b418f73b65)) * Update dependency com.google.cloud:google-iam-policy to v1.6.1 ([#434](https://togithub.com/googleapis/java-iam/issues/434)) ([18d4bc0](https://togithub.com/googleapis/java-iam/commit/18d4bc0cd7341123d00eeb5fa15606d058f12fa6)) * Update dependency com.google.protobuf:protobuf-java to v3.21.7 ([#463](https://togithub.com/googleapis/java-iam/issues/463)) ([8ad215f](https://togithub.com/googleapis/java-iam/commit/8ad215f4543f7ffcd891ed6e1b202fe1ddccd86f)) * Update dependency gcp-releasetool to v1.8.8 ([#441](https://togithub.com/googleapis/java-iam/issues/441)) ([31fec95](https://togithub.com/googleapis/java-iam/commit/31fec95f348f55c98dab665bec47d88f396a9611)) * Update dependency google-api-core to v2.10.1 ([#446](https://togithub.com/googleapis/java-iam/issues/446)) ([50d8221](https://togithub.com/googleapis/java-iam/commit/50d82218cb3056bb49173d7f5d4e7b0070717b0f)) * Update dependency google-auth to v2.12.0 ([#447](https://togithub.com/googleapis/java-iam/issues/447)) ([97b4c23](https://togithub.com/googleapis/java-iam/commit/97b4c236276d27be1e290334573ec6897c9e67c9)) * Update dependency google-cloud-core to v2.3.2 ([#442](https://togithub.com/googleapis/java-iam/issues/442)) ([00adc9a](https://togithub.com/googleapis/java-iam/commit/00adc9a8bf225a4c3d1509f9e6778ad10dd16e2e)) * Update dependency google-cloud-storage to v2.5.0 ([#448](https://togithub.com/googleapis/java-iam/issues/448)) ([df5cf74](https://togithub.com/googleapis/java-iam/commit/df5cf74ee883b7f4d99ce9654fcdd6a4670cc98a)) * Update dependency google-crc32c to v1.5.0 ([#449](https://togithub.com/googleapis/java-iam/issues/449)) ([a2f7304](https://togithub.com/googleapis/java-iam/commit/a2f7304a602b4621f43d4b3966586e0a7e1a7a2d)) * Update dependency googleapis-common-protos to v1.56.4 ([#443](https://togithub.com/googleapis/java-iam/issues/443)) ([c64de5a](https://togithub.com/googleapis/java-iam/commit/c64de5a5b2f3fcd9e17ed4963e586aaf0a1209ba)) * Update dependency importlib-metadata to v4.12.0 ([#450](https://togithub.com/googleapis/java-iam/issues/450)) ([e8607ce](https://togithub.com/googleapis/java-iam/commit/e8607ce4d1c6b202726b185560920c742e056a30)) * Update dependency io.grpc:grpc-protobuf to v1.49.2 ([#464](https://togithub.com/googleapis/java-iam/issues/464)) ([0d24035](https://togithub.com/googleapis/java-iam/commit/0d2403530080668411981679ec01801d5e756e03)) * Update dependency io.grpc:grpc-stub to v1.49.2 ([#465](https://togithub.com/googleapis/java-iam/issues/465)) ([2b67643](https://togithub.com/googleapis/java-iam/commit/2b67643239cf9cf617ddd3d15d176fbdb574d15e)) * Update dependency jeepney to v0.8.0 ([#451](https://togithub.com/googleapis/java-iam/issues/451)) ([56c8f86](https://togithub.com/googleapis/java-iam/commit/56c8f86e437f49636edd5673b4336def947de475)) * Update dependency jinja2 to v3.1.2 ([#452](https://togithub.com/googleapis/java-iam/issues/452)) ([0ebc062](https://togithub.com/googleapis/java-iam/commit/0ebc06212f4dc10f8724f35705d1db9ab148beac)) * Update dependency markupsafe to v2.1.1 ([#454](https://togithub.com/googleapis/java-iam/issues/454)) ([93bd5ec](https://togithub.com/googleapis/java-iam/commit/93bd5ec7183cf306e4956261321038b923861276)) * Update dependency protobuf to v3.20.2 ([#455](https://togithub.com/googleapis/java-iam/issues/455)) ([fb47671](https://togithub.com/googleapis/java-iam/commit/fb47671168b256e9b76ecc16e52cf0674cbefce7)) * Update dependency protobuf to v4 ([#460](https://togithub.com/googleapis/java-iam/issues/460)) ([cb9637c](https://togithub.com/googleapis/java-iam/commit/cb9637ce2ed8976deda7a146a3df738f6afd158c)) * Update dependency pyjwt to v2.5.0 ([#461](https://togithub.com/googleapis/java-iam/issues/461)) ([2d696a0](https://togithub.com/googleapis/java-iam/commit/2d696a04f036369b25a3dceb29f8f1b855136890)) * Update dependency requests to v2.28.1 ([#456](https://togithub.com/googleapis/java-iam/issues/456)) ([b023d05](https://togithub.com/googleapis/java-iam/commit/b023d05d096ae796573c488869682c45f1de57b2)) * Update dependency typing-extensions to v4.3.0 ([#457](https://togithub.com/googleapis/java-iam/issues/457)) ([53a369c](https://togithub.com/googleapis/java-iam/commit/53a369c5f157bcfb2752c6b6503d2f5e76c226b8)) * Update dependency zipp to v3.8.1 ([#458](https://togithub.com/googleapis/java-iam/issues/458)) ([39ea408](https://togithub.com/googleapis/java-iam/commit/39ea4087f4b72a57ee09d6f312d05f7607d89bfb)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #420.
Notice that #420 will be fixed only when this is merged/rebased in all other branches.