Skip to content

Remove storage todos #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2015
Merged

Remove storage todos #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,6 @@ public StorageObject compose(Iterable<StorageObject> sources, StorageObject targ
Map<Option, ?> targetOptions) throws StorageException {
ComposeRequest request = new ComposeRequest();
if (target.getContentType() == null) {
// todo: remove once this is no longer requirement (b/20681287).
target.setContentType("application/octet-stream");
}
request.setDestination(target);
Expand All @@ -311,7 +310,6 @@ public StorageObject compose(Iterable<StorageObject> sources, StorageObject targ
}
request.setSourceObjects(sourceObjects);
try {
// todo: missing setProjection (b/20659000)
return storage.objects()
.compose(target.getBucket(), target.getName(), request)
.setIfMetagenerationMatch(IF_METAGENERATION_MATCH.getLong(targetOptions))
Expand Down Expand Up @@ -435,7 +433,6 @@ public byte[] read(StorageObject from, Map<Option, ?> options, long position, in
.setIfGenerationMatch(IF_GENERATION_MATCH.getLong(options))
.setIfGenerationNotMatch(IF_GENERATION_NOT_MATCH.getLong(options));
MediaHttpDownloader downloader = req.getMediaHttpDownloader();
// todo: Fix int casting (https://github.com/google/google-api-java-client/issues/937)
downloader.setContentRange(position, (int) position + bytes);
downloader.setDirectDownloadEnabled(true);
ByteArrayOutputStream output = new ByteArrayOutputStream();
Expand Down
2 changes: 0 additions & 2 deletions gcloud-java-storage/src/main/java/com/google/gcloud/storage/StorageImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,6 @@ public RetryResult beforeEval(Exception exception) {
StorageImpl(StorageOptions options) {
super(options);
storageRpc = options.storageRpc();
// todo: provide rewrite - https://cloud.google.com/storage/docs/json_api/v1/objects/rewrite
// todo: check if we need to expose https://cloud.google.com/storage/docs/json_api/v1/bucketAccessControls/insert vs using bucket update/patch
}

@Override
Expand Down