Add whenDone method and CompletionCallback to Job and Operation #1016

mziccard · 2016-05-19T14:46:23Z

This PR adds a friendly method to wait for Job and Operation to complete, in the current thread. Methods accept a callback that can be used to react to job/operation failure or success. This fixes #963.

/cc @jgeewax @lesv

coveralls · 2016-05-19T15:10:15Z

Coverage increased (+0.01%) to 85.987% when pulling e29f635 on mziccard:when-done into d5cf726 on GoogleCloudPlatform:master.

gcloud-java-bigquery/src/main/java/com/google/cloud/bigquery/Job.java

+   * @throws BigQueryException upon failure
+   * @throws InterruptedException if the current thread gets interrupted while waiting for the job
+   *     to complete
+   */


coveralls · 2016-05-23T13:01:09Z

Coverage increased (+0.008%) to 85.972% when pulling c3ce162 on mziccard:when-done into fceeb65 on GoogleCloudPlatform:master.

mziccard · 2016-05-23T13:08:09Z

In c3ce162 I removed whenDone as well as the callback class. Instead, I added two blocking methods (waitFor and waitFor(int, TimeUnit)) that return the completed job/operation (on null if not found).

You should like this better no :)

README.md

 import com.google.cloud.compute.Snapshot;

-Compute compute = ComputeOptions.defaultInstance().service();
+final Compute compute = ComputeOptions.defaultInstance().service();


aozarov · 2016-05-23T16:56:37Z

Yes, I like it. One more suggestion and javadoc needs some cleanup.

lesv · 2016-05-27T04:33:47Z

ping

coveralls · 2016-05-30T10:38:02Z

Coverage increased (+0.008%) to 86.043% when pulling e5af988 on mziccard:when-done into 11f4573 on GoogleCloudPlatform:master.

mziccard · 2016-05-30T11:00:05Z

In e5af988 I added vararg options for both the checking period and the timeout. How do you like it now?

I had to rebase to fix conflicts and trigger CI.

gcloud-java-compute/src/main/java/com/google/cloud/compute/Operation.java

+   */
+  public Operation waitFor(WaitForOption... waitOptions)
+      throws InterruptedException, TimeoutException {
+    Map<WaitForOption.Option, ?> optionMap = WaitForOption.asMap(waitOptions);


coveralls · 2016-06-02T11:16:38Z

Coverage increased (+0.02%) to 86.05% when pulling 71cd868 on mziccard:when-done into 11f4573 on GoogleCloudPlatform:master.

aozarov · 2016-06-03T04:12:44Z

I like the change now! I will leave it to @lesv to do a thorough review but looks good to me.

coveralls · 2016-06-03T06:25:31Z

Coverage increased (+0.05%) to 86.085% when pulling 996bae5 on mziccard:when-done into 11f4573 on GoogleCloudPlatform:master.

lesv · 2016-06-07T16:21:05Z

LGTM

…14.5 (#1016) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.14.3` -> `2.14.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.6/compatibility-slim/2.14.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.6/confidence-slim/2.14.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform).

🤖 I have created a release *beep* *boop* --- ## [3.3.0](googleapis/java-aiplatform@v3.2.0...v3.3.0) (2022-09-15) ### Features * add input_artifacts to PipelineJob.runtime_config in aiplatform v1 pipeline_job ([ff7a4ab](googleapis/java-aiplatform@ff7a4ab)) * Add model_monitoring_stats_anomalies,model_monitoring_status to BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto ([#1041](googleapis/java-aiplatform#1041)) ([fe03c60](googleapis/java-aiplatform@fe03c60)) * Add read_mask to ListPipelineJobsRequest in aiplatform v1 pipeline_service ([#1032](googleapis/java-aiplatform#1032)) ([ff7a4ab](googleapis/java-aiplatform@ff7a4ab)) * Add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1 index_service.proto ([#1030](googleapis/java-aiplatform#1030)) ([4114021](googleapis/java-aiplatform@4114021)) * add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1beta1 index_service.proto ([4114021](googleapis/java-aiplatform@4114021)) * Add WriteFeatureValues in aiplatform v1beta1 featurestore_online_service.proto ([#1022](googleapis/java-aiplatform#1022)) ([267827e](googleapis/java-aiplatform@267827e)) ### Dependencies * Update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.18.0 ([#1021](googleapis/java-aiplatform#1021)) ([c3d34a0](googleapis/java-aiplatform@c3d34a0)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#1016](googleapis/java-aiplatform#1016)) ([cc0af7b](googleapis/java-aiplatform@cc0af7b)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#1026](googleapis/java-aiplatform#1026)) ([6ed66cc](googleapis/java-aiplatform@6ed66cc)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#1031](googleapis/java-aiplatform#1031)) ([5adefd4](googleapis/java-aiplatform@5adefd4)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#1040](googleapis/java-aiplatform#1040)) ([b6c1b20](googleapis/java-aiplatform@b6c1b20)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#1044](googleapis/java-aiplatform#1044)) ([5ce52e5](googleapis/java-aiplatform@5ce52e5)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1043](googleapis/java-aiplatform#1043)) ([40eae55](googleapis/java-aiplatform@40eae55)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1045](googleapis/java-aiplatform#1045)) ([0f66302](googleapis/java-aiplatform@0f66302)) * Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#1015](googleapis/java-aiplatform#1015)) ([7a2fcb0](googleapis/java-aiplatform@7a2fcb0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

chore: remove check for flatten plugin We have had the check for the flatten-maven-plugin in each Cloud Java client repository. However, the behavior of the plugin has been stable and its not each repository's responsibility to assert the plugin's behavior. A new check is going to be added at the googleapis/java-shared-config repository to assert the plugin's behavior when we upgrade its version. Source-Link: googleapis/synthtool@9266ddc Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ae72564aa9c368b9ccd96f4af21f87889fd83b9e60635b80844deb5a2ccd08aa Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* cleanup: remove migrated sample * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

mziccard added api: bigquery Issues related to the BigQuery API. api: compute Issues related to the Compute Engine API. labels May 19, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2016

aozarov reviewed May 19, 2016
View reviewed changes

mziccard force-pushed the when-done branch from 9ba2701 to c3ce162 Compare May 23, 2016 12:55

aozarov reviewed May 23, 2016
View reviewed changes

README.md Outdated

import com.google.cloud.compute.Snapshot;

Compute compute = ComputeOptions.defaultInstance().service();

final Compute compute = ComputeOptions.defaultInstance().service();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

mziccard added 4 commits May 30, 2016 12:16

Add whenDone method and CompletionCallback to BigQuery Job

c53560d

Add whenDone method and CompletionCallback to Compute Operation

a185e4c

Add blocking waitFor method, remove whenDone and callback

fe296fa

Remove no-longer-necessary final

197ddeb

mziccard force-pushed the when-done branch from 2c5f323 to 96da766 Compare May 30, 2016 10:20

Add vararg options (WaitForOption) to waitFor method

e5af988

mziccard force-pushed the when-done branch from 96da766 to e5af988 Compare May 30, 2016 10:31

aozarov reviewed May 31, 2016
View reviewed changes

Add CheckingPeriod and Timeout subclasses to WaitForOption

71cd868

Remove hashCode and equals from base class, support null default value

996bae5

mziccard merged commit 3b35a9e into googleapis:master Jun 9, 2016

Add whenDone method and CompletionCallback to Job and Operation #1016

Add whenDone method and CompletionCallback to Job and Operation #1016

Uh oh!

Conversation

mziccard commented May 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented May 19, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented May 23, 2016

Uh oh!

mziccard commented May 23, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented May 23, 2016

Uh oh!

lesv commented May 27, 2016

Uh oh!

coveralls commented May 30, 2016

Uh oh!

mziccard commented May 30, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Jun 2, 2016

Uh oh!

aozarov commented Jun 3, 2016

Uh oh!

coveralls commented Jun 3, 2016

Uh oh!

lesv commented Jun 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mziccard commented May 19, 2016 •

edited

Loading