-
Notifications
You must be signed in to change notification settings - Fork 415
perf: Change StreamingReadRpc::Read interface to take ResponseType #15319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This allows the caller to allocate the ResponseType on an arena and better matches the underlying GRPC interface
/gcbrun |
Fixed the generator and now |
/gcbrun |
Fixed clang errors |
Friendly ping |
/gcbrun |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15319 +/- ##
==========================================
+ Coverage 92.97% 92.99% +0.02%
==========================================
Files 2402 2402
Lines 217996 218108 +112
==========================================
+ Hits 202672 202824 +152
+ Misses 15324 15284 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/gcbrun |
Friendly ping. Seem like the only tests not running need another level of approval |
This allows the caller to allocate the ResponseType on an arena and better matches the underlying GRPC interface
TESTED=bazel test //google/... --test_tag_filters=-integration-test,-benchmark,-sample
This change is