Skip to content

perf: Change StreamingReadRpc::Read interface to take ResponseType #15319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

andrewro-google
Copy link

@andrewro-google andrewro-google commented Jul 25, 2025

This allows the caller to allocate the ResponseType on an arena and better matches the underlying GRPC interface

TESTED=bazel test //google/... --test_tag_filters=-integration-test,-benchmark,-sample


This change is Reviewable

This allows the caller to allocate the ResponseType on an arena
and better matches the underlying GRPC interface
@andrewro-google andrewro-google requested review from a team as code owners July 25, 2025 23:56
@andrewro-google andrewro-google changed the title Change StreamingReadRpc::Read interface to take ResponseType perf: Change StreamingReadRpc::Read interface to take ResponseType Jul 26, 2025
@scotthart
Copy link
Member

/gcbrun

@andrewro-google
Copy link
Author

Fixed the generator and now bazel test //... --test_tag_filters=-integration-test,-benchmark,-sample and bazel build //... passes

@scotthart
Copy link
Member

/gcbrun

@andrewro-google
Copy link
Author

Fixed clang errors

@andrewro-google
Copy link
Author

Friendly ping

@scotthart
Copy link
Member

/gcbrun

Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 99.16840% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.99%. Comparing base (ac99ef0) to head (4f37d9a).

Files with missing lines Patch % Lines
...cloud/bigtable/internal/default_row_reader_test.cc 98.16% 2 Missing ⚠️
...v1/internal/golden_kitchen_sink_connection_impl.cc 85.71% 1 Missing ⚠️
...loud/internal/resumable_streaming_read_rpc_test.cc 98.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15319      +/-   ##
==========================================
+ Coverage   92.97%   92.99%   +0.02%     
==========================================
  Files        2402     2402              
  Lines      217996   218108     +112     
==========================================
+ Hits       202672   202824     +152     
+ Misses      15324    15284      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
Copy link
Member

/gcbrun

@andrewro-google
Copy link
Author

Friendly ping. Seem like the only tests not running need another level of approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants