[pointer] Add separate PtrInner
#1891
Merged
+698
−503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
commented
Oct 12, 2024
joshlf
commented
Oct 12, 2024
joshlf
commented
Oct 12, 2024
joshlf
commented
Oct 12, 2024
joshlf
force-pushed
the
ptr-inner
branch
3 times, most recently
from
403a13c to
4a51127
Compare
joshlf
changed the title
PtrInner
joshlf
force-pushed
the
ptr-inner
branch
3 times, most recently
from
5879a7e to
47a4678
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1891 +/- ##
==========================================
- Coverage 87.68% 87.65% -0.04%
==========================================
Files 16 17 +1
Lines 5938 5964 +26
==========================================
+ Hits 5207 5228 +21
- Misses 731 736 +5 ☔ View full report in Codecov by Sentry. |
jswrenn
approved these changes
Oct 14, 2024
joshlf
force-pushed
the
ptr-inner
branch
2 times, most recently
from
869dc7c to
1b205a0
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
`PtrInner` carries all invariants which are not controlled by type parameters. Since `PtrInner` does not promise to uphold aliasing, alignment, or validity, we can move some utility methods to `PtrInner` which previously were responsible for maintaining invariants orthogonal to their purpose. Makes progress on #1892 (still needs to be fixed on v0.8.x) Closes #1890
joshlf
added a commit
that referenced
this pull request
Feb 24, 2025
`PtrInner` carries all invariants which are not controlled by type parameters. Since `PtrInner` does not promise to uphold aliasing, alignment, or validity, we can move some utility methods to `PtrInner` which previously were responsible for maintaining invariants orthogonal to their purpose. Makes progress on #1892 (still needs to be fixed on v0.8.x) Closes #1890 gherrit-pr-id: I1c2d4a54bc1d73d3079d043c2bc393a8967f44f6
|
Backporting in #2380 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
`PtrInner` carries all invariants which are not controlled by type parameters. Since `PtrInner` does not promise to uphold aliasing, alignment, or validity, we can move some utility methods to `PtrInner` which previously were responsible for maintaining invariants orthogonal to their purpose. Makes progress on #1892 (still needs to be fixed on v0.8.x) Closes #1890 gherrit-pr-id: I1c2d4a54bc1d73d3079d043c2bc393a8967f44f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PtrInnercarries all invariants which are not controlled by type parameters. SincePtrInnerdoes not promise to uphold aliasing, alignment, or validity, we can move some utility methods toPtrInnerwhich previously were responsible for maintaining invariants orthogonal to their purpose.Makes progress on #1892 (still needs to be fixed on v0.8.x)
Closes #1890