[WIP] Generic pointer/reference types

[joshlf]

For a more minimal implementation, see #1209.

This is part of #1183.

[Copilot]

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (4)

src/pointer/ptr.rs:367

• [nitpick] The function name 'from_foo' is non-descriptive; consider renaming it to better reflect its conversion purpose.

pub fn from_foo<R: super::super::Pointer<'a, T, Aliasing = Aliasing>>(r: R) -> Self {

src/pointer/ptr.rs:370

• The safety comment 'SAFETY: TODO' should be replaced with a detailed justification that explains why using Ptr::new is valid here.

unsafe { Ptr::new(ptr) }

src/lib.rs:1759

• [nitpick] The function name 'ref_from_foo' is non-descriptive; consider renaming it to better convey its functionality converting a byte slice to a pointer.

fn ref_from_foo<'a, B: 'a + pointer::Pointer<'a, [u8]>>(bytes: B) -> Option<B::Pointer<Self>> {

src/pointer/mod.rs:140

• The safety comment in the Box implementation should be expanded with a detailed explanation of why it is safe to call NonNull::new_unchecked with the raw pointer.

// SAFETY: TODO

[Copilot]

The unsafe block in the into_box method lacks a detailed safety justification; please add a clear explanation of the invariants that must be maintained.

Suggested change

	// SAFETY: TODO
	// SAFETY: The pointer `raw` is obtained from `self.as_non_null().as_ptr()`, which ensures that:
	// - `raw` is non-null, as `NonNull::as_ptr` guarantees a non-null pointer.
	// - `raw` is properly aligned, as `Ptr` ensures alignment invariants.
	// - `raw` points to a valid allocation, as `Ptr` ensures validity invariants.
	// Therefore, it is safe to convert `raw` into a `Box`.