Bump SDK dependency to 3.3.0, replace removed dart:typed_data type in test code
#953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Unmodifiable...View` types were deprecated in favor of `asModifiableView`s members introduced in SDK 3.3.0. These types are now removed, so the protobuf package tests can't be built with the most recent SDK. Bump the SDK dependency to 3.3.0 (the version introduced `asModifiableView`) and replace the removed type with `asModifiableView` in the test.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
osa1
changed the title
dart:typed_data type in test codedart:typed_data type in test code
devoncarew
approved these changes
Feb 5, 2025
| @@ -1,4 +1,4 @@ | |||
| # Created with package:mono_repo v6.5.7 | |||
| # Created with package:mono_repo v6.6.2 | |||
There was a problem hiding this comment.
We can also move away from using this mono_repo generated workflow file - in favor of some simple hand-written ones - if that's preferable.
There was a problem hiding this comment.
I think it's fine, I don't have any problems with it.
There was a problem hiding this comment.
#957 moves to using simple, hand-written workflow files per-package instead of a generated mono_repo one.
| @@ -6,5 +6,4 @@ stages: | |||
| - format | |||
| - command: ./../tool/setup.sh | |||
| - command: ./compile_protos.sh | |||
| - analyze: --fatal-infos | |||
There was a problem hiding this comment.
+1 to removing this package
| // supported SDK version. | ||
| // ignore: deprecated_member_use | ||
| testWithList(UnmodifiableUint8ListView(Uint8List.fromList(inputBuffer))); | ||
| testWithList(Uint8List.fromList(inputBuffer).asUnmodifiableView()); |
| @@ -644,7 +644,7 @@ class FileGenerator extends ProtobufContainer { | |||
| // Generated code. Do not modify. | |||
| // source: ${descriptor.name} | |||
| // | |||
| // @dart = 2.12 | |||
| // @dart = 3.3 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unmodifiable...Viewtypes were deprecated in favor ofasModifiableViews members introduced in SDK 3.3.0.These types are now removed, so the protobuf package tests can't be built with the most recent SDK.
Bump the SDK dependency to 3.3.0 (the version introduced
asModifiableView) and replace the removed type withasModifiableViewin the test.Fix new warnings with 3.3.0 in protoc_plugin tests and generated code.
Remove legacy tests in protoc_plugin as we no longer support unsound versions of Dart.
This PR also makes some small changes to make CI happy:
Fix analyzer issues in protobuf.
api_benchmark is getting bitrot, make analyzer issues in api_benchmark non-fatal so that we can run other CI jobs when it fails.
GitHub CI config is re-generated with the most recent mono_repo.
Closes #936.