Apply internally enabled lints #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables lints `prefer_final_in_for_each` and `prefer_final_locals` and fixes lints errors. These lints were previously enabled in internal version in the following CLs: - cl/523340795: updated protoc_plugin source - cl/523340868: updated protoc_plugin tests - cl/523340813: updated protobuf source protobuf tests are not yet updated internally. Majority of the changes are generated by `dart fix --apply`. Manual changes were done in two places: - `dart fix` does not fix lints in `<type> <var> = <expr>;` syntax, it looks like it only replaces `var` with `final` and does not add `final` before a type. A few lint errors were fixed manually for this. - protoc_plugin/lib/src/client_generator.dart updated manually to fix the lints in generated code. The difference in generated code can be seen in changes in `protoc_plugin/test/goldens`.
domesticmouse
approved these changes
Apr 13, 2023
natebosch
approved these changes
Apr 13, 2023
devoncarew
approved these changes
Apr 25, 2023
|
Can land @osa1 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables lints
prefer_final_in_for_eachandprefer_final_localsand fixes lints errors.These lints were previously enabled in internal version in the following CLs:
Majority of the changes are generated by
dart fix --apply. Manual changes were done in two places:dart fixdoes not fix lints in<type> <var> = <expr>;syntax, it looks like it only replacesvarwithfinaland does not addfinalbefore a type. A few lint errors were fixed manually for this.protoc_plugin/lib/src/client_generator.dart updated manually to fix the lints in generated code. The difference in generated code can be seen in changes in
protoc_plugin/test/goldens.