-
Notifications
You must be signed in to change notification settings - Fork 640
profile: avoid string(int) conversion #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As per the vet check being introduced in 1.15 (golang/go#32479), conversions of the form string(int) are flagged by go vet. The suggested fix is to instead use string(rune). Additionally, since google/pprof is vendored into the go tree, we avoid test failures from vet flagging this dependency (see CL https://go-review.googlesource.com/c/go/+/220977).
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
=======================================
Coverage 67.06% 67.06%
=======================================
Files 37 37
Lines 7611 7611
=======================================
Hits 5104 5104
Misses 2103 2103
Partials 404 404
Continue to review full report at Codecov.
|
Bump from 20191205061153 => 20201109224723 My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`) Includes: - google/pprof#564 - google/pprof#575 - google/pprof#574 - google/pprof#571 - google/pprof#572 - google/pprof#570 - google/pprof#562 - google/pprof#561 - google/pprof#565 - google/pprof#560 - google/pprof#563 - google/pprof#557 - google/pprof#554 - google/pprof#552 - google/pprof#545 - google/pprof#549 - google/pprof#547 - google/pprof#541 - google/pprof#534 - google/pprof#542 - google/pprof#535 - google/pprof#531 - google/pprof#530 - google/pprof#528 - google/pprof#522 - google/pprof#525 - google/pprof#527 - google/pprof#519 - google/pprof#520 - google/pprof#517 - google/pprof#518 - google/pprof#514 - google/pprof#513 - google/pprof#510 - google/pprof#508 - google/pprof#506 - google/pprof#509 - google/pprof#504
* Update pprof to latest revision Bump from 20191205061153 => 20201109224723 My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`) Includes: - google/pprof#564 - google/pprof#575 - google/pprof#574 - google/pprof#571 - google/pprof#572 - google/pprof#570 - google/pprof#562 - google/pprof#561 - google/pprof#565 - google/pprof#560 - google/pprof#563 - google/pprof#557 - google/pprof#554 - google/pprof#552 - google/pprof#545 - google/pprof#549 - google/pprof#547 - google/pprof#541 - google/pprof#534 - google/pprof#542 - google/pprof#535 - google/pprof#531 - google/pprof#530 - google/pprof#528 - google/pprof#522 - google/pprof#525 - google/pprof#527 - google/pprof#519 - google/pprof#520 - google/pprof#517 - google/pprof#518 - google/pprof#514 - google/pprof#513 - google/pprof#510 - google/pprof#508 - google/pprof#506 - google/pprof#509 - google/pprof#504 * Update P/pprof/build_tarballs.jl - use a real version number Co-authored-by: Mosè Giordano <[email protected]> * Remove now unused `timestamp` * [pprof] Use `GitSource` Co-authored-by: Mosè Giordano <[email protected]>
As per the vet check being introduced in 1.15 (golang/go#32479), conversions of the form string(int) are flagged by go vet. The suggested fix is to instead use string(rune). Additionally, since google/pprof is vendored into the go tree, we avoid test failures from vet flagging this dependency (see CL https://go-review.googlesource.com/c/go/+/220977).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #513 +/- ##
=======================================
Coverage 67.06% 67.06%
=======================================
Files 37 37
Lines 7611 7611
=======================================
Hits 5104 5104
Misses 2103 2103
Partials 404 404 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As per the vet check being introduced in 1.15
(golang/go#32479), conversions of the form
string(int) are flagged by go vet. The suggested fix is to instead use
string(rune).
Additionally, since google/pprof is vendored into the go tree, we avoid
test failures from vet flagging this dependency (see
CL https://go-review.googlesource.com/c/go/+/220977).