Skip to content

Conversation

@randomPoison
Copy link
Collaborator

At some point we started using todo instead of unimplemented, but a couple places still use the old macro. May as well normalize on todo everywhere, since unimplemented is baaaaaaasically deprecated.

@fw-immunant
Copy link
Collaborator

It's fine to make things consistent everywhere, but since when is unimplemented! on the way out? I thought it was for functionality that isn't and shouldn't be implemented.

@randomPoison
Copy link
Collaborator Author

randomPoison commented Jan 30, 2025

Oh fair point, I didn't think about unimplemented meaning "deliberately unimplemented"

The difference between unimplemented! and todo! is that while todo! conveys an intent of implementing the functionality later and the message is “not yet implemented”, unimplemented! makes no such claims. Its message is “not implemented”.

So todo! still probably makes more sense for us to use in the exercise code, but unimplemented isn't deprecated in the way I thought.

@djmitche djmitche self-requested a review January 31, 2025 17:33
Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency is good! Both macros are mentioned in the macros page, so I don't think this is losing anything.

@randomPoison
Copy link
Collaborator Author

Both macros are mentioned in the macros page

tbh I kinda want to remove unimplemented! from the macros slide as well since we never end up using it in the course. I guess I'll throw up a PR for that so we can discuss.

@randomPoison randomPoison merged commit 72c7618 into main Feb 6, 2025
37 checks passed
@randomPoison randomPoison deleted the legare/goodbye-unimplemented branch February 6, 2025 20:35
michael-kerscher pushed a commit to michael-kerscher/comprehensive-rust that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants