Remove unnecessary dependency on cel_proto_wrap_util #1332
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, cel_proto_wrap_util #includes "eval/testutil/test_message.pb.h" even though I don't think it is used anywhere. This results in an otherwise unnecessary dependency on the test protos in a non-test target.
Collaborator
|
/gcbrun |
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
Remove unnecessary dependency on cel_proto_wrap_util. PiperOrigin-RevId: 736847393
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
Apply PR #1332 @jchadwick-buf PiperOrigin-RevId: 736847393
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
Apply PR #1332 @jchadwick-buf PiperOrigin-RevId: 736847393
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
Apply PR #1332 @jchadwick-buf PiperOrigin-RevId: 736860598
Author
|
This was applied, so I presume we can close it now. |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, cel_proto_wrap_util
#includes "eval/testutil/test_message.pb.h" even though I don't think it is used anywhere. This results in an otherwise unnecessary dependency on the test protos in a non-test target.