Fix for slot calculation for block expressions. #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_694696083
branch
2 times, most recently
from
9b0b9eb to
44a4208
Compare
With this change, all comprehension variables inside cel.@block are assigned to a dedicated slot. It's hard to identify when they can be safely reused with lazy evaluation and likely doesn't provide enough benefit to try to reuse them more aggressively. PiperOrigin-RevId: 694717283
copybara-service
bot
force-pushed
the
test_694696083
branch
from
44a4208 to
c4f9b58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for slot calculation for block expressions.
With this change, all comprehension variables inside cel.@block are assigned to a dedicated slot. It's hard to identify when they can be safely reused with lazy evaluation and likely doesn't provide enough benefit to try to reuse them more aggressively.