Skip to content

Silence gcc overloaded-virtual warning in FieldBackedMapImpl #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Silence gcc overloaded-virtual warning in FieldBackedMapImpl #1048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions eval/public/containers/internal_field_backed_map_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ class FieldBackedMapImpl : public CelMap {
// Presence test function.
absl::StatusOr<bool> Has(const CelValue& key) const override;

// This is here exclusively to silence gcc overloaded-virtual warning which,
// depending on the compilation options, can be converted to an error.
//
// As per https://gcc.gnu.org/onlinedocs/gcc-13.1.0/gcc/C_002b_002b-Dialect-Options.html#index-Woverloaded-virtual
// you can silence this gcc warning by adding a using declaration for the
// "hidden" method.
using CelMap::ListKeys;

absl::StatusOr<const CelList*> ListKeys() const override;

protected:
Expand Down