Fix critical bugs in MLE-STAR data leakage checker #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix TypeError: replace_leakage_code() missing required 'prefix' argument by adding functools.partial() wrapper consistent with other callbacks - Fix UnboundLocalError: leakage_status undefined in exception handler by setting leakage_status = 'Unknown' in except block These bugs caused crashes when use_data_leakage_checker=True, preventing users from utilizing this important MLE-STAR feature for detecting data leakage in machine learning competitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed two critical bugs in the data leakage checker that caused crashes when
use_data_leakage_checker=True.Bugs Fixed
Bug 1: Missing functools.partial() wrapper
TypeError: replace_leakage_code() missing 1 required positional argument: 'prefix'after_model_callbackwas not wrapped withfunctools.partial()to pass theprefixparameterfunctools.partial()wrapper consistent with other callbacks in the same fileBug 2: Undefined variable in exception handling
UnboundLocalError: cannot access local variable 'leakage_status' where it is not associated with a valueleakage_statuswas not defined in theexceptblock ofupdate_extract_status()leakage_status = "Unknown"in the exception handlerImpact
Testing
use_data_leakage_checker=Trueon a task using this feature.