-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix data-science agent deployment failure with None environment varia… #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix data-science agent deployment failure with None environment varia… #276
Conversation
…bles - Filter out None and empty string values from env_vars dictionary - Add logging for skipped environment variables - Maintain backward compatibility with empty strings in .env files - Fixes TypeError when BQML_RAG_CORPUS_NAME and CODE_INTERPRETER_EXTENSION_NAME are empty Fixes google#192
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a deployment failure in the data-science agent caused by None environment variables being passed to the agent engine. The fix filters out None and empty string values from environment variables while maintaining backward compatibility.
- Implements filtering logic to exclude None, empty, and whitespace-only environment variables
- Adds logging for better visibility into which environment variables are being skipped or included
- Includes code formatting improvements for consistency
…bles - Filter out None, empty, and whitespace-only values from env_vars dictionary - Add logging for skipped environment variables - Maintain backward compatibility with empty strings in .env files - Fixes TypeError when BQML_RAG_CORPUS_NAME and CODE_INTERPRETER_EXTENSION_NAME are empty Fixes google#192
1c013d3
to
e30ca22
Compare
Yes, please, fix the cod einthe DS project so that it can work well with env variables. It is quite easy, just add somethihng like model=os.getenv("ROOT_AGENT_MODEL", "gemini-2.5-flash") |
This pull request primarily improves code readability and robustness in the Environment variable handling:
Logging and error handling:
Code formatting and style:
Cloud resource setup:
These changes collectively make the deployment script easier to maintain, less error-prone, and more transparent during execution. |
Dear @5Y5TEM, I wanted to kindly remind you to review this pull request at your earliest convenience. Please let me know if you have any questions or require additional information from my side. Thank you for your attention and support. |
…bles
Fixes #192