Skip to content

chore: Fix spelling #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-file-contents.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:
- name: Check for import from cli package in certain changed Python files
run: |
git fetch origin ${{ github.base_ref }}
CHANGED_FILES=$(git diff --diff-filter=ACMR --name-only origin/${{ github.base_ref }}...HEAD | grep -E '\.py$' | grep -v -E 'cli/.*|tests/.*|contributing/samples/' || true)
CHANGED_FILES=$(git diff --diff-filter=ACMR --name-only origin/${{ github.base_ref }}...HEAD | grep -E '\.py$' | grep -v -E 'cli/.*|src/google/adk/tools/apihub_tool/apihub_toolset.py|tests/.*|contributing/samples/' || true)
Copy link
Author

@jsoref jsoref Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI gets really mad without this, but it isn't my job to refactor this repository to make CI happy.

if [ -n "$CHANGED_FILES" ]; then
echo "Changed Python files to check:"
echo "$CHANGED_FILES"
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ $ ./autoformat.sh

### In ADK source

Below styles applies to the ADK source code (under `src/` folder of the Github.
Below styles applies to the ADK source code (under `src/` folder of the GitHub.
repo).

#### Use relative imports
Expand Down
19 changes: 9 additions & 10 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

### Improvements

* Add Github workflow config for the ADK Answering agent ([8dc0c94](https://github.com/google/adk-python/commit/8dc0c949afb9024738ff7ac1b2c19282175c3200))
* Add GitHub workflow config for the ADK Answering agent ([8dc0c94](https://github.com/google/adk-python/commit/8dc0c949afb9024738ff7ac1b2c19282175c3200))
* Import AGENT_CARD_WELL_KNOWN_PATH from adk instead of from a2a directly ([37dae9b](https://github.com/google/adk-python/commit/37dae9b631db5060770b66fce0e25cf0ffb56948))
* Make `LlmRequest.LiveConnectConfig` field default to a factory ([74589a1](https://github.com/google/adk-python/commit/74589a1db7df65e319d1ad2f0676ee0cf5d6ec1d))
* Update the prompt to make the ADK Answering Agent more objective ([2833030](https://github.com/google/adk-python/commit/283303032a174d51b8d72f14df83c794d66cb605))
Expand Down Expand Up @@ -80,14 +80,13 @@
### Features

* [Core]Add agent card builder ([18f5bea](https://github.com/google/adk-python/commit/18f5bea411b3b76474ff31bfb2f62742825b45e5))
* [Core]Add an to_a2a util to convert adk agent to A2A ASGI application ([a77d689](https://github.com/google/adk-python/commit/a77d68964a1c6b7659d6117d57fa59e43399e0c2))
* [Core]Add a to_a2a util to convert adk agent to A2A ASGI application ([a77d689](https://github.com/google/adk-python/commit/a77d68964a1c6b7659d6117d57fa59e43399e0c2))
* [Core]Add camel case converter for agents ([0e173d7](https://github.com/google/adk-python/commit/0e173d736334f8c6c171b3144ac6ee5b7125c846))
* [Evals]Use LocalEvalService to run all evals in cli and web ([d1f182e](https://github.com/google/adk-python/commit/d1f182e8e68c4a5a4141592f3f6d2ceeada78887))
* [Evals]Enable FinalResponseMatchV2 metric as an experiment ([36e45cd](https://github.com/google/adk-python/commit/36e45cdab3bbfb653eee3f9ed875b59bcd525ea1))
* [Models]Add support for `model-optimizer-*` family of models in vertex ([ffe2bdb](https://github.com/google/adk-python/commit/ffe2bdbe4c2ea86cc7924eb36e8e3bb5528c0016))
* [Services]Added a sample for History Management ([67284fc](https://github.com/google/adk-python/commit/67284fc46667b8c2946762bc9234a8453d48a43c))
* [Services]Support passing fully qualified agent engine resource name when constructing session service and memory service ([2e77804](https://github.com/google/adk-python/commit/2e778049d0a675e458f4e
35fe4104ca1298dbfcf))
* [Services]Support passing fully qualified agent engine resource name when constructing session service and memory service ([2e77804](https://github.com/google/adk-python/commit/2e778049d0a675e458f4e35fe4104ca1298dbfcf))
* [Tools]Add ComputerUseToolset ([083dcb4](https://github.com/google/adk-python/commit/083dcb44650eb0e6b70219ede731f2fa78ea7d28))
* [Tools]Allow toolset to process llm_request before tools returned by it ([3643b4a](https://github.com/google/adk-python/commit/3643b4ae196fd9e38e52d5dc9d1cd43ea0733d36))
* [Tools]Support input/output schema by fully-qualified code reference ([dfee06a](https://github.com/google/adk-python/commit/dfee06ac067ea909251d6fb016f8331065d430e9))
Expand Down Expand Up @@ -200,7 +199,7 @@

### Documentation

* Update the a2a exmaple link in README.md [d0fdfb8](https://github.com/google/adk-python/commit/d0fdfb8c8e2e32801999c81de8d8ed0be3f88e76)
* Update the a2a example link in README.md [d0fdfb8](https://github.com/google/adk-python/commit/d0fdfb8c8e2e32801999c81de8d8ed0be3f88e76)
* Adds AGENTS.md to provide relevant project context for the Gemini CLI [37108be](https://github.com/google/adk-python/commit/37108be8557e011f321de76683835448213f8515)
* Update CONTRIBUTING.md [ffa9b36](https://github.com/google/adk-python/commit/ffa9b361db615ae365ba62c09a8f4226fb761551)
* Add adk project overview and architecture [28d0ea8](https://github.com/google/adk-python/commit/28d0ea876f2f8de952f1eccbc788e98e39f50cf5)
Expand Down Expand Up @@ -395,7 +394,7 @@
* Fix typos in README for sample bigquery_agent and oauth_calendar_agent ([9bdd813](https://github.com/google/adk-python/commit/9bdd813be15935af5c5d2a6982a2391a640cab23))
* Make tool_call one span for telemetry and renamed to execute_tool ([999a7fe](https://github.com/google/adk-python/commit/999a7fe69d511b1401b295d23ab3c2f40bccdc6f))
* Use media type in chat window. Remove isArtifactImage and isArtifactAudio reference ([1452dac](https://github.com/google/adk-python/commit/1452dacfeb6b9970284e1ddeee6c4f3cb56781f8))
* Set output_schema correctly for LiteLllm ([6157db7](https://github.com/google/adk-python/commit/6157db77f2fba4a44d075b51c83bff844027a147))
* Set output_schema correctly for LiteLlm ([6157db7](https://github.com/google/adk-python/commit/6157db77f2fba4a44d075b51c83bff844027a147))
* Update pending event dialog style ([1db601c](https://github.com/google/adk-python/commit/1db601c4bd90467b97a2f26fe9d90d665eb3c740))
* Remove the gap between event holder and image ([63822c3](https://github.com/google/adk-python/commit/63822c3fa8b0bdce2527bd0d909c038e2b66dd98))

Expand Down Expand Up @@ -423,7 +422,7 @@
## 1.1.1

### Features
* Add BigQuery first-party tools. See [here](https://github.com/google/adk-python/commit/d6c6bb4b2489a8b7a4713e4747c30d6df0c07961) for more details.
* Add [BigQuery first-party tools](https://github.com/google/adk-python/commit/d6c6bb4b2489a8b7a4713e4747c30d6df0c07961) for more details.


## 1.1.0
Expand Down Expand Up @@ -559,7 +558,7 @@
* Fix google search reading undefined for `renderedContent`.

### Miscellaneous Chores
* Docstring improvements, typo fixings, github action to enfore code styles on formatting and imports, etc.
* Docstring improvements, typo fixings, github action to enforce code styles on formatting and imports, etc.

## 0.3.0

Expand Down Expand Up @@ -598,7 +597,7 @@

### ⚠ BREAKING CHANGES

* Fix typo in method name in `Event`: has_trailing_code_exeuction_result --> has_trailing_code_execution_result.
* Fix typo in method name in `Event`: has_trailing_code_execution_result --> has_trailing_code_execution_result.

### Features

Expand Down Expand Up @@ -628,7 +627,7 @@

### Miscellaneous Chores

* Adds unit tests in Github action.
* Adds unit tests in GitHub action.
* Improves test coverage.
* Various typo fixes.

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ This project follows
## Requirement for PRs

- Each PR should only have one commit. Please squash it if there are multiple PRs.
- All PRs, other than small documentation or typo fixes, should have a Issue assoicated. If not, please create one.
- All PRs, other than small documentation or typo fixes, should have a Issue associated. If not, please create one.
- Small, focused PRs. Keep changes minimal—one concern per PR.
- For bug fixes or features, please provide logs or screenshot after the fix is applied to help reviewers better understand the fix.
- Please include a `testing plan` section in your PR to talk about how you will test. This will save time for PR review. See `Testing Requirements` section for more details.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
Use the provided tools to conduct various operations on users' data in Google BigQuery.
Scenario 1:
The user wants to query their biguqery datasets
The user wants to query their bigquery datasets
Use bigquery_datasets_list to query user's datasets
Scenario 2:
Expand Down
2 changes: 1 addition & 1 deletion contributing/samples/a2a_human_in_loop/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ Agent: ✅ Great news! Your reimbursement has been approved by the manager. Proc
The human-in-the-loop process follows this pattern:

1. **Initial Call**: Root agent delegates approval request to remote approval agent for amounts >$100
2. **Pending Response**: Remote approval agent returns immediate response with `status: "pending"` and ticket ID and serface the approval request to root agent
2. **Pending Response**: Remote approval agent returns immediate response with `status: "pending"` and ticket ID and surface the approval request to root agent
3. **Agent Acknowledgment**: Root agent informs user about pending approval status
4. **Human Interaction**: Human manager interacts with root agent to review and approve/reject the request
5. **Updated Response**: Root agent receives updated tool response with approval decision and send it to remote agent
Expand Down
2 changes: 1 addition & 1 deletion contributing/samples/adk_answering_agent/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Or `python -m adk_answering_agent.answer_discussions --recent 10` to answer the

## GitHub Workflow Mode

The `main.py` is reserved for the Github Workflow. The detailed setup for the automatic workflow is TBD.
The `main.py` is reserved for the GitHub Workflow. The detailed setup for the automatic workflow is TBD.

---

Expand Down
6 changes: 3 additions & 3 deletions contributing/samples/adk_answering_agent/agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@
1. Use the `get_discussion_and_comments` tool to get the details of the discussion including the comments.
2. Focus on the latest comment but reference all comments if needed to understand the context.
* If there is no comment at all, just focus on the discussion title and body.
3. If all the following conditions are met, try to add a comment to the discussion, otherwise, do not respond:
3. If all the following conditions are met, try to add a comment to the discussion; otherwise, do not respond:
* The discussion is not closed.
* The latest comment is not from you or other agents (marked as "Response from XXX Agent").
* The latest comment is asking a question or requesting information.
4. Use the `VertexAiSearchTool` to find relevant information before answering.
5. If you can find relevant information, use the `add_comment_to_discussion` tool to add a comment to the discussion.
6. If you post a commment and the discussion does not have a label named {BOT_RESPONSE_LABEL},
6. If you post a comment and the discussion does not have a label named {BOT_RESPONSE_LABEL},
add the label {BOT_RESPONSE_LABEL} to the discussion using the `add_label_to_discussion` tool.


Expand All @@ -63,7 +63,7 @@
information that is not in the document store. Do not invent citations which are not in the document store.
* **Be Objective**: your answer should be based on the facts you found in the document store, do not be misled by user's assumptions or user's understanding of ADK.
* If you can't find the answer or information in the document store, **do not** respond.
* Inlclude a short summary of your response in the comment as a TLDR, e.g. "**TLDR**: <your summary>".
* Include a short summary of your response in the comment as a TLDR, e.g. "**TLDR**: <your summary>".
* Have a divider line between the TLDR and your detail response.
* Do not respond to any other discussion except the one specified by the user.
* Please include your justification for your decision in your output
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ async def list_most_recent_discussions(count: int = 1) -> list[int] | None:
def process_arguments():
"""Parses command-line arguments."""
parser = argparse.ArgumentParser(
description="A script that answer questions for Github discussions.",
description="A script that answer questions for GitHub discussions.",
epilog=(
"Example usage: \n"
"\tpython -m adk_answering_agent.answer_discussions --recent 10\n"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def upload_directory_to_gcs(
)
return False

print(f"Sucessfully uploaded {file_count} files to GCS.")
print(f"Successfully uploaded {file_count} files to GCS.")
return True


Expand All @@ -135,7 +135,7 @@ def import_from_gcs_to_vertex_ai(
# parent has the format of
# "projects/{project_number}/locations/{location}/collections/{collection}/dataStores/{datastore_id}/branches/default_branch"
parent=full_datastore_id + "/branches/default_branch",
# Specify the GCS source and use "content" for unstructed data.
# Specify the GCS source and use "content" for unstructured data.
gcs_source=discoveryengine.GcsSource(
input_uris=[gcs_uri], data_schema="content"
),
Expand Down
4 changes: 2 additions & 2 deletions contributing/samples/adk_answering_agent/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def convert_gcs_to_https(gcs_uri: str) -> Optional[str]:
# Use the directory path if it is a index file
final_path_segment = os.path.dirname(path_after_docs)
else:
# Otherwise, use the file name without extention
# Otherwise, use the file name without extension
final_path_segment = path_after_docs.removesuffix(".md")

if final_path_segment and not final_path_segment.endswith("/"):
Expand All @@ -139,7 +139,7 @@ def convert_gcs_to_https(gcs_uri: str) -> Optional[str]:
if _check_url_exists(potential_url):
return potential_url
else:
# If it doesn't exist, fallback to the regular github url
# If it doesn't exist, fall back to the regular github url
return _generate_github_url(prefix, relative_path)

# Convert the links for other cases, e.g. adk-python
Expand Down
8 changes: 4 additions & 4 deletions contributing/samples/adk_issue_formatting_agent/agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@


def list_open_issues(issue_count: int) -> dict[str, Any]:
"""List most recent `issue_count` numer of open issues in the repo.
"""List most recent `issue_count` number of open issues in the repo.
Args:
issue_count: number of issues to return
Expand Down Expand Up @@ -75,7 +75,7 @@ def get_issue(issue_number: int) -> dict[str, Any]:
"""Get the details of the specified issue number.
Args:
issue_number: issue number of the Github issue.
issue_number: issue number of the GitHub issue.
Returns:
The status of this request, with the issue details when successful.
Expand All @@ -92,7 +92,7 @@ def add_comment_to_issue(issue_number: int, comment: str) -> dict[str, any]:
"""Add the specified comment to the given issue number.
Args:
issue_number: issue number of the Github issue
issue_number: issue number of the GitHub issue
comment: comment to add
Returns:
Expand All @@ -116,7 +116,7 @@ def list_comments_on_issue(issue_number: int) -> dict[str, any]:
"""List all comments on the given issue number.
Args:
issue_number: issue number of the Github issue
issue_number: issue number of the GitHub issue
Returns:
The the status of this request, with the list of comments when successful.
Expand Down
2 changes: 1 addition & 1 deletion contributing/samples/adk_pr_agent/agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def get_github_pr_info_http(pr_number: int) -> str | None:
system_prompt = """
You are a helpful assistant to generate reasonable descriptions for pull requests for software engineers.

The descritions should not be too short (e.g.: less than 3 words), or too long (e.g.: more than 30 words).
The descriptions should not be too short (e.g.: less than 3 words), or too long (e.g.: more than 30 words).

The generated description should start with `chore`, `docs`, `feat`, `fix`, `test`, or `refactor`.
`feat` stands for a new feature.
Expand Down
16 changes: 8 additions & 8 deletions contributing/samples/adk_pr_triaging_agent/agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def get_pull_request_details(pr_number: int) -> str:
"""Get the details of the specified pull request.

Args:
pr_number: number of the Github pull request.
pr_number: number of the GitHub pull request.

Returns:
The status of this request, with the details when successful.
Expand Down Expand Up @@ -160,7 +160,7 @@ def add_label_and_reviewer_to_pr(pr_number: int, label: str) -> dict[str, Any]:
"""Adds a specified label and requests a review from a mapped reviewer on a PR.

Args:
pr_number: the number of the Github pull request
pr_number: the number of the GitHub pull request
label: the label to add

Returns:
Expand All @@ -173,7 +173,7 @@ def add_label_and_reviewer_to_pr(pr_number: int, label: str) -> dict[str, Any]:
f"Error: Label '{label}' is not an allowed label. Will not apply."
)

# Pull Request is a special issue in Github, so we can use issue url for PR.
# Pull Request is a special issue in GitHub, so we can use issue url for PR.
label_url = (
f"{GITHUB_BASE_URL}/repos/{OWNER}/{REPO}/issues/{pr_number}/labels"
)
Expand Down Expand Up @@ -216,15 +216,15 @@ def add_comment_to_pr(pr_number: int, comment: str) -> dict[str, Any]:
"""Add the specified comment to the given PR number.

Args:
pr_number: the number of the Github pull request
pr_number: the number of the GitHub pull request
comment: the comment to add

Returns:
The the status of this request, with the applied comment when successful.
"""
print(f"Attempting to add comment '{comment}' to issue #{pr_number}")

# Pull Request is a special issue in Github, so we can use issue url for PR.
# Pull Request is a special issue in GitHub, so we can use issue url for PR.
url = f"{GITHUB_BASE_URL}/repos/{OWNER}/{REPO}/issues/{pr_number}/comments"
payload = {"body": comment}

Expand All @@ -244,7 +244,7 @@ def add_comment_to_pr(pr_number: int, comment: str) -> dict[str, Any]:
description="Triage ADK pull requests.",
instruction=f"""
# 1. Identity
You are a Pull Request (PR) triaging bot for the Github {REPO} repo with the owner {OWNER}.
You are a Pull Request (PR) triaging bot for the GitHub {REPO} repo with the owner {OWNER}.

# 2. Responsibilities
Your core responsibility includes:
Expand All @@ -262,7 +262,7 @@ def add_comment_to_pr(pr_number: int, comment: str) -> dict[str, Any]:
- If it's about session, memory, artifacts services, label it with "services"
- If it's about UI/web, label it with "web"
- If it's related to tools, label it with "tools"
- If it's about agent evalaution, then label it with "eval".
- If it's about agent evaluation, then label it with "eval".
- If it's about streaming/live, label it with "live".
- If it's about model support(non-Gemini, like Litellm, Ollama, OpenAI models), label it with "models".
- If it's about tracing, label it with "tracing".
Expand Down Expand Up @@ -297,7 +297,7 @@ def add_comment_to_pr(pr_number: int, comment: str) -> dict[str, Any]:
# 4. Steps
When you are given a PR, here are the steps you should take:
- Call the `get_pull_request_details` tool to get the details of the PR.
- Skip the PR (i.e. do not label or comment) if the PR is closed or is labeled with "{BOT_LABEL}" or "google-contributior".
- Skip the PR (i.e. do not label or comment) if the PR is closed or is labeled with "{BOT_LABEL}" or "google-contributor".
- Check if the PR is following the contribution guidelines.
- If it's not following the guidelines, recommend or add a comment to the PR that points to the contribution guidelines (https://github.com/google/adk-python/blob/main/CONTRIBUTING.md).
- If it's following the guidelines, recommend or add a label to the PR.
Expand Down
Loading