feat: Support adding prefix to tool names returned by toolset #2400
+346
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
added
the
google-contributor
copybara-service
bot
force-pushed
the
copybara/791983427
branch
from
7dd3662 to
291a6c4
Compare
This is to address the name conflict issue of tools returned by different toolset. Mainly it's to give each toolset a namespace. We have a flag `add_tool_name_prefix` to decide whether to apply this behavior We have a `tool_name_prefix` to let client specify a custom prefix, if not set , toolset name will be used as prefix. PiperOrigin-RevId: 791983427
copybara-service
bot
force-pushed
the
copybara/791983427
branch
from
291a6c4 to
2c6acd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Support adding prefix to tool names returned by toolset
This is to address the name conflict issue of tools returned by different toolset. Mainly it's to give each toolset a namespace.
We have a flag
add_tool_name_prefixto decide whether to apply this behaviorWe have a
tool_name_prefixto let client specify a custom prefix, if not set , toolset name will be used as prefix.