-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: Update adk_app handling to use custom module without .py extension #2374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Response from ADK Triaging Agent Hello @vinodseshadri, thank you for creating this PR! This PR is a bug fix, could you please provide the command line output after the fix is applied? This information will help reviewers to review your PR more efficiently. Thanks! |
Here is execution with no adk_app added
Below example with a test_adk.py file in the agent folder with
|
Pull Request Description
This pull request addresses a critical issue in the
cli_deploy.py
module -where in theadk_app
was ignoredIssues fixed
fixes #2298
Changes done
adk_app
is set and if it is then copy the py file from agent source folder instead of creatingadd_app
to a constant so that it can be revisited later easily