-
Notifications
You must be signed in to change notification settings - Fork 131
feat(run): adds Worker Pool support to deploy-cloudrun action #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR. I'm supportive of adding worker pool (assuming it has been added on the same model as jobs) We are looking for someone at Google to review the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matbrito Thanks for your initial work on updating this GitHub Action. I haven't finished reviewing, but I wanted to give you some initial feedback. Overall, the approach looks consistent to how jobs/services work.
Hi @iennae, thanks for your initial review, i've just made some code changes related to the comments you left. I'm totally open to new comments and suggestions |
Add support do worker pool. Some considerations of this PR are placed below: