Migrate /corgi #4419
Merged
Migrate /corgi #4419
+76
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemini-cli
bot
added
the
status/need-issue
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @abhipatel12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request marks the completion of the command migration project by moving the final legacy command, /corgi, to the new command structure. This crucial step enabled the comprehensive removal of the entire legacy command processing system, resulting in a significantly streamlined and more maintainable codebase.
Highlights
- Command Migration Completion: The
/corgicommand, the final legacy command, has been successfully migrated to the new, standardized command architecture. - Legacy Command System Removal: The entire deprecated legacy command processing infrastructure has been eliminated. This includes the
LegacySlashCommandinterface, thelegacyCommandsarray, and all associated fallback logic within theslashCommandProcessor.tshook. - Codebase Streamlining: The
useSlashCommandProcessorhook has been significantly simplified by removing parameters and internal logic that were solely tied to the old command system, leading to a leaner and more maintainable codebase. - Enhanced Test Coverage: A new dedicated test file (
corgiCommand.test.ts) has been added for the migrated command, and existing test suites (CommandService.test.ts,slashCommandProcessor.test.ts) have been updated to reflect the new command structure and the removal of legacy components.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x' artifact from the main CI run. |
|
😂 Corgi mode. Last but not least! Thanks for the review! |
skeshive
pushed a commit
that referenced
this pull request
Jul 18, 2025
dacian3
pushed a commit
to dacian3/gemini-cli
that referenced
this pull request
Jul 20, 2025
thacio
added a commit
to thacio/auditaria
that referenced
this pull request
Jul 21, 2025
galz10
pushed a commit
that referenced
this pull request
Jul 22, 2025
davenportjw
pushed a commit
to davenportjw/gemini-cli
that referenced
this pull request
Jul 24, 2025
jkcinouye
pushed a commit
that referenced
this pull request
Jul 25, 2025
|
Hi there! What's corgi mode? And what can I do with it? |
|
@YdayangY Corgi mode is just a UI effect that gets toggled when you're in the CLI. You should see a corgi in the bottom right if you use |
galz10
pushed a commit
that referenced
this pull request
Jul 30, 2025
JunYang-tes
pushed a commit
to JunYang-tes/gemini-cli.nvim
that referenced
this pull request
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
This PR completes the command migration project by migrating the final legacy command,
/corgi, to the new command structure. With this change, the entire legacy command processing system, including thelegacyCommandsarray and related fallback logic inslashCommandProcessor.ts, has been removed.Dive Deeper
The migration of the
/corgicommand followed the established plan:packages/cli/src/ui/commands/corgiCommand.ts.corgiCommand.test.ts, was added to ensure the command's functionality is covered.CommandService.tsand its test file.The most significant part of this PR is the cleanup phase. Since
/corgiwas the last command, I was able to:LegacySlashCommandinterface.legacyCommandsarray and theuseMemohook that created it.handleSlashCommandfunction.allCommandsmemoized value and its associated logic for adapting legacy commands.useSlashCommandProcessorhook's signature and dependency arrays, removing props that were only used by the legacy system.This leaves the
slashCommandProcessorhook much leaner.Reviewer Test Plan
npm start./corgiand press Enter./corgiagain and press Enter./help,/theme,/clear) to ensure that the removal of the legacy system has not caused any regressions./foocorrectly displays an "Unknown command" error.Testing Matrix