-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Upload VSIX of companion VS Code extension #4241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @skeshive, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is a foundational step for the VS Code companion extension, focusing on making it distributable and ready for eventual public release. It involves packaging the extension into a VSIX file for immediate use and configuring its metadata and build process to align with marketplace publication requirements.
Highlights
- Extension Distribution Enablement: This PR enables the temporary installation of the VS Code companion extension by uploading its VSIX file, which can be used via the
/ide install
command. - Marketplace Publication Preparation: The extension is prepared for future marketplace publication by adding essential metadata to
package.json
, including a publisher, icon path, and repository URL. - Licensing and Packaging Configuration: An Apache License 2.0 file has been added, and a
.vscodeignore
file was introduced to precisely control which files are included in the final VSIX package. - Build Script Refinements: The
package.json
scripts have been updated to streamline the VSIX creation process, ensuring type checks, linting, and production builds are run before packaging.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares the VS Code companion extension for packaging and distribution by adding a license, .vscodeignore
file, and updating package.json
with publisher and repository information. The review identifies two high-severity issues: one in .vscodeignore
concerning non-standard patterns that could break packaging, and another in package.json
regarding the format of the repository URL for a monorepo package. Both issues include suggestions for correction to align with best practices and ensure tool compatibility.
Code Coverage Summary
CLI Package - Full Text Report
Core Package - Full Text Report
For detailed HTML reports, please see the 'coverage-reports-22.x' artifact from the main CI run. |
Co-authored-by: matt korwel <[email protected]>
Co-authored-by: matt korwel <[email protected]>
Co-authored-by: matt korwel <[email protected]>
Co-authored-by: matt korwel <[email protected]>
TLDR
This PR uploads the VS Code companion extension's VSIX file. This VSIX will be used for temporary installation via the /ide install command. Once we're ready to publish to the marketplace, we'll replace this with a GitHub Action for automatic builds/publishing and /ide install will then fetch the published version.
Dive Deeper
Linked issues / bugs
This issue makes progress towards #4166