Fix nightly Release #3511
Merged
Fix nightly Release #3511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous tsconfig.json was including test-related files and directories in the build output, causing the npm package to fail at runtime due to missing devDependencies. This change updates the 'exclude' array in packages/cli/tsconfig.json to correctly ignore all test files and the test-utils directory, ensuring a clean and functional build.
The previous workflow was attempting to install the @google/gemini-cli-core package using an npm tag, which was causing the release to fail. This change updates the workflow to install the package using the specific version number, ensuring that the correct dependency is installed and the release can proceed.
|
the nightly build from utc 07/08 won't run. gemini thinks its one of these 2 issues. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @mattKorwel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to address a potential race condition that may have caused a recent nightly build failure. The primary change involves updating the tsconfig.json file to exclude additional test-related files and directories, which may help stabilize the build process.
Highlights
- Build Configuration: The
tsconfig.jsonfile for theclipackage has been updated to exclude test files with the.tsxextension and thesrc/test-utilsdirectory from the build process.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
NTaylorMullen
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Code Review
This pull request aims to fix a nightly release by excluding test files from the TypeScript build, which is a good step towards improving build hygiene. However, the change is incomplete as it doesn't exclude all configured test file patterns (e.g., *.spec.ts(x) files). I've added a comment with a suggestion to address this to make the build more robust and fully prevent test code from leaking into production artifacts.
Comment on lines
+19
to
+20
| "src/**/*.test.ts", | ||
| "src/**/*.test.tsx", |
There was a problem hiding this comment.
While this correctly excludes *.test.tsx files, the vitest.config.ts for this package is also configured to find *.spec.ts and *.spec.tsx files. To ensure all test files are excluded from the production build and prevent the kind of issue this PR is trying to fix, it's important to exclude spec files as well.
You can use glob brace expansion to cover both patterns concisely.
"src/**/*.{test,spec}.ts",
"src/**/*.{test,spec}.tsx",
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-24.x' artifact from the main CI run. |
gemini-cli
bot
added
the
status/need-issue
mainroach
pushed a commit
that referenced
this pull request
Jul 9, 2025
slhck
pushed a commit
to slhck/gemini-cli
that referenced
this pull request
Jul 9, 2025
JunYang-tes
pushed a commit
to JunYang-tes/gemini-cli.nvim
that referenced
this pull request
Jul 12, 2025
davenportjw
pushed a commit
to davenportjw/gemini-cli
that referenced
this pull request
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
I'm not 100% sure this fixes it but I think maybe we hit a race condition on the last broken nightly build.
This led to a successful test build.