-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(cli): update ascii art for smaller screens #3117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @rmedranollamas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the CLI's user experience by improving the display of the application's ASCII art logo across various terminal sizes. It introduces a new, highly compact logo and refines the logic for selecting the optimal logo based on the terminal's available width, ensuring a better visual presentation, especially on smaller screens like mobile devices.
Highlights
- New Compact ASCII Art: A new, more compact ASCII art logo has been introduced, specifically designed for smaller screen sizes or terminal widths. This new logo is now assigned to
shortAsciiLogo
. - Logo Renaming: The previously existing
shortAsciiLogo
has been renamed tomediumAsciiLogo
to accommodate the new, even smaller logo. - Dynamic Logo Selection: The
Header
component's logic has been updated to dynamically select the most appropriate ASCII art logo based on the available terminal width. It now prioritizes thelongAsciiLogo
, thenmediumAsciiLogo
, and finally the newshortAsciiLogo
if neither of the larger ones fit.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully introduces a new, more compact ASCII art logo and refactors the existing one to be a 'medium' size. The Header
component has been updated to dynamically select the most appropriate logo based on the terminal width, ensuring a better user experience on smaller screens. The changes are well-implemented and the logic for selecting the ASCII art is clear and correct. No critical or high-severity issues were identified in this review.
Hey Ramon, can you please file an issue to pair this to? |
64767c5
this is related to #2183 |
This commit introduces a new, more compact ASCII
art logo for the
short
version and makes theexisting one called
medium
logo.The
Header
component has been updated tocorrectly handle the three different logo sizes,
selecting the largest one that fits within the
terminal's width.
TLDR
When using mobile devices, the existing logo is too large and produces a view that is typically broken due to the line wrap. I have added a smaller logo than 70 char width and made the other two being handled.
Reviewer Test Plan
Run the tests on a mac device with different wide terminals :)
Testing Matrix