-
Notifications
You must be signed in to change notification settings - Fork 6.8k
📦 NEW: Theme Shades of Purple #2114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📦 NEW: Theme Shades of Purple #2114
Conversation
We have a number of pull requests to add custom themes. Unfortunately we can't accept them all as the theme dialog will get overrun with themes. If anything we should have fewer themes then we have today. This is however a pretty compelling theme so if we can figure out an existing theme to remove, I'm open to adding this. A lot of the existing themes are similar. @miguelsolorio may have ideas about which of the existing themes we should consider removing to add this., This issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we actually have room for one more line in the theme dialog before it overflows the vertical height of the default so approving as this theme is more unique than most of the other themes that all look similar. Thank you for the contribution and I'm looking forward to using this theme myself.
Thank you @jacob314. Excited to get this approved. Over five million developers use Shades of Purple theme. One of the top five VS Code themes. With 150 different themes, I care deeply about how code is syntax highlighted. Let’s get another review to speed things along. Excited to share it with purplers. |
Co-authored-by: Scott Densmore <[email protected]>
Love this @ahmadawais !!! Also really makes me think we need to build in theming into our extension system asap 🤔 |
Co-authored-by: Scott Densmore <[email protected]>
Co-authored-by: Scott Densmore <[email protected]>
Co-authored-by: Scott Densmore <[email protected]>
Co-authored-by: Scott Densmore <[email protected]>
Co-authored-by: Scott Densmore <[email protected]>
TLDR
This PR adds the Shades of Purple theme for syntax highlighting in the Gemini CLI. The theme provides a beautiful dark purple aesthetic with vibrant color accents for enhanced code readability and visual appeal.
Dive Deeper
The Shades of Purple theme is a comprehensive syntax highlighting theme that includes:
The theme follows the existing architecture pattern:
ColorsTheme
interface with required color definitionsTheme
class with proper TypeScript typesTechnical Implementation:
shades-of-purple.ts
with complete theme definitiontheme-manager.ts
to register the new themeReviewer Test Plan
To validate this change:
Build and run the CLI:
Test theme switching:
/theme
command to open theme selectorTest syntax highlighting:
what would a diff file demo look like in a form of a patch
Testing Matrix
Testing completed:
Linked issues / bugs
No specific issues linked - this is a new feature addition bringing a popular community theme to the Gemini CLI for enhanced developer experience.
Note: I am the creator of the original popular Shades of Purple VS Code theme.