Skip to content

fix: default hyperparams to float32 unless specified #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: default hyperparams to float32 unless specified #1445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions optax/schedules/_inject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,7 @@ def wrapped_transform(
def init_fn(params):
count = jnp.zeros([], jnp.int32)
if hyperparam_dtype is None:
dtype = getattr(
next(iter(jax.tree.leaves(params)), None), 'dtype', None
)
dtype = jnp.float32
else:
dtype = hyperparam_dtype
hparams = {
Expand All @@ -175,9 +173,7 @@ def init_fn(params):

def update_fn(updates, state, params=None, **extra_args):
if hyperparam_dtype is None:
dtype = getattr(
next(iter(jax.tree.leaves(updates)), None), 'dtype', None
)
dtype = jnp.float32
else:
dtype = hyperparam_dtype
hparams = {
Expand Down
Loading