fix: gracefully handle InvalidStateError: Failed to start the audio device #1764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Feature
This PR addresses unhandled promise rejections that occur when AudioContext.resume() fails in restrictive environments like mobile webviews, throwing the error "InvalidStateError: Failed to start the audio device".
Related Issues
Fixes #1743
Solution
Added
.catch()handler toctx.resume()to handle resume failuresAdded a new
resumeerrorevent that applications can listen to for error handlingReproduction/Testing
Breaking Changes
No breaking changes. The new resumeerror event is additive. ctx.resume() failures now catch unhandled promise rejections. There are no API changes