This repository was archived by the owner on Jun 27, 2023. It is now read-only.
Implement OverridableController to allow for mock overrides #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@codyoss can we get this merged? will be helpful. |
Add Uber maintainers.
This rewrites the import path from "github.com/golang/mock" to "go.uber.org/mock".
Ran go mod tidy and removed a bunch of unused dependencies from go.sum. Ideally we should run this as part of some lint check step as we do in other uber-go repositories.
Update README to reflect: - current status - installation path - supported Go versions - Remove irrelevant info
from Go 1.19, `go fmt` reformats doc comments. https://go.dev/doc/go1.19#go-doc > Go 1.19 adds support for links, lists, and clearer headings in doc comments. As part of this change, [gofmt](https://go.dev/cmd/gofmt) now reformats doc comments to make their rendered meaning clearer. See “[Go Doc Comments](https://go.dev/doc/comment)” for syntax details and descriptions of common mistakes now highlighted by gofmt. As another part of this change, the new package [go/doc/comment](https://go.dev/pkg/go/doc/comment/) provides parsing and reformatting of doc comments as well as support for rendering them to HTML, Markdown, and text.
Go 1.18 is no longer supported. Now, we can bump Go version to 1.19.
- Bump checkout/setup-go actions versions - Drop pre-1.18 action - Edit action permissions to readonly
This preps v0.1.0 release. Added a CHANGELOG file to keep track of release changes according to semver. Ref golang#17.
Originally discussed in golang#238. This adds a functional option parameter to NewController to allow adding future configurations to control the behavior of Controller. This will come in handy for implementing features like the one in golang#22.
styeung
force-pushed
the
saitoy/overridable-mock
branch
from
5f713a8 to
a473650
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of the proposal outlined in this issue, Proposal: Provide an option where every invocation of EXPECT() of a mock should override any previous invocations. #685