Honor implicit page type ("page") when selecting template

[jmooring]

In relation to the new template system, this has been discussed before, but I'd like to revisit it.

Consider this project structure:

content/
└── p1.md

layouts/
├── page/
│   └── page.html
└── page.html

When the page type is explicitly set to "page" in front matter, Hugo renders p1.md using layouts/page/page.html as expected.

However, when the page type is implicitly set to "page" Hugo renders p1.md using layouts/page.html instead.

Without digging into the details, I suspect that this method has no impact on template selection:

hugo/hugolib/page__meta.go

Lines 226 to 238 in dd6e2c8

	const defaultContentType = "page"
	func (p *pageMeta) Type() string {
	if p.pageConfig.Type != "" {
	return p.pageConfig.Type
	}
	if sect := p.Section(); sect != "" {
	return sect
	}
	return defaultContentType
	}

Reference: https://discourse.gohugo.io/t/possible-bug-single-layout-for-pages-in-v0-147-9/55179/

[bep]

Without digging into the details, I suspect that this method has no impact on template selection:

• You are right. type in template selection is either type (if set) or section (first directory).
• Since this path is meant to match a real content path, it made no sense to me to fall back to the rather arbitrary /page, but If it fixes some issues in the wild, I don't see any problem adding that fallback. I haven't looked at the code, but I think that means using .Page.Type() directly instead of what's there.

[bep]

hugo/hugolib/page.go

Line 482 in dd6e2c8

base := p.PathInfo().BaseReTyped(p.m.pageConfig.Type)