Add missing useModelFront parameter to GodotSharp Basis and Transform
#79082
Conversation
raulsntos
left a comment
raulsntos
left a comment
There was a problem hiding this comment.
Thanks for contributing to the .NET module and helping keep it in sync with Core. This looks good already, just making a few comments about things that can be improved.
|
@raulsntos Thanks for your review. I did not know that adding optional parameters would break binary compatibility, but it makes sense that it does. It wasn't clear from your comments if you wanted me to move the compat methods to the Compat class? |
raulsntos
left a comment
raulsntos
left a comment
There was a problem hiding this comment.
It wasn't clear from your comments if you wanted me to move the compat methods to the Compat class?
That's what I did, tell me if it's alright.
Sorry about that. It's fine either way, we have never added compat methods for non-generated types before so we don't currently have previous precedent. Usually I keep overloads close to each other, so maybe keeping them in their respective types would be better.
geowarin
force-pushed
the
master
branch
2 times, most recently
from
f96011e to
82c2afe
Compare
|
@raulsntos Gotcha! Should be good now 😄 |
To LookAt methods. Also adds Vector3 Model constants. These were not added after godotengine#76082 was merged.
|
The build error seems unrelated to this change if I'm not mistaken. |
|
Thanks! Sorry for no reply earlier. You didn't need to do anything, we restarted the build and it has passed. |
|
@YuriSizov Don't worry about it! I really appreciate your work. Thank you ❤️ |
YuriSizov
changed the title
useModelFront parameter to GodotSharp Basis and Transform
|
Cherry-picked for 4.1.2. |
5 participants
On LookAt methods.
Also adds Vector3 Model constants.
These were not added after #76082 was merged.