Refactor CurveEdit to use consistent world/view transforms
#77622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
For reference, "World" is the space of the curve, i.e. x from 0 to 1, and y = f(x). "View" is the pixel coordinates of stuff on the screen, relative to the top left corner of the curve editor. |
anvilfolk
commented
May 29, 2023
anvilfolk
force-pushed
the
curvywurvy
branch
2 times, most recently
from
fbfa331 to
f49be2b
Compare
MewPurPur
reviewed
May 29, 2023
anvilfolk
force-pushed
the
curvywurvy
branch
2 times, most recently
from
862a1d0 to
27dbf0c
Compare
Contributor
|
Looks good to me |
anvilfolk
force-pushed
the
curvywurvy
branch
from
27dbf0c to
7f9b1ba
Compare
Currently, `CurveEdit` uses a couple of different ways to ensure that points and lines are drawn in the right space. This makes the code harder to understand and maintain. This PR makes the curve be drawn in view coordinates by transforming every point from world/curve-space into view-space. By drawing in view-space, we can keep enable anti-aliasing and use a single way to transform coordinates from the two different spaces.
anvilfolk
force-pushed
the
curvywurvy
branch
from
7d419e9 to
67be52b
Compare
Contributor
Author
|
Rebased. This has been reviewed & tested by the person who last worked intensely on the curve editor. It is on the path towards #67857, which has decent support and I'd like to revive since I need it for myself :) Do we need reviews from someone else? |
Contributor
Author
|
Closed as included in #67857. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
CurveEdituses a couple of different ways to ensure that points and lines are drawn in the right space. This makes the code harder to understand and maintain.This PR makes the curve be drawn in view coordinates by transforming every point from world/curve-space into view-space. This ensures there is a single way to scale from curve-space to view-space and vice-versa. By drawing in view-space, we can keep anti-aliasing, which was the main point of the previous changes! 🥳
Other minor changes, resulting in fewer lines of code overall:
plot_curve_accuratetoCurveEditso it can make use of_world_to_viewtransform and related functionsconst Vector2 &