Add a method in Curve to predict insertion index #75030
Open
+30
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MewPurPur
reviewed
Mar 17, 2023
Rindbee
force-pushed
the
predict-insertion-index
branch
3 times, most recently
from
0e30a69 to
0d12779
Compare
Find the one with the largest index if there are multiple points with equal x
Rindbee
force-pushed
the
predict-insertion-index
branch
from
b1df8e5 to
278dc29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the way to get the index of the point being added was by calling
add_point()to get its return value. Now it's computed, which may help implement improvements to the Curver editor (like in #74959).