Fix engine freezes by changing curve offset #111344
Open
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
changed the title
AThousandShips
changed the title
Contributor
|
There were some previous concerns with this style of implementation, which you can see here #74959 (review). It does look like you found a situation where it's consistently a problem! I'm not sure this is a complete fix - could there be a situation in which the loop still keeps going around? I'd love it if we could find an algorithm that does the same thing but without these concerns! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111330
While control was held, the offset was shifted by too little on each iteration of the loop.
Also added a check for coming from the left to fix a visual glitch.