Skip to content

Conversation

@mihe
Copy link
Contributor

@mihe mihe commented Jul 31, 2025

Fixes #109129.

This makes explicit that we don't support logging from the Logger virtual methods, which happened to be possible prior #108860 (mostly as a "happy accident") but which no longer is.

@mihe mihe added this to the 4.5 milestone Jul 31, 2025
@mihe mihe requested a review from a team as a code owner July 31, 2025 18:42
@Repiteo Repiteo modified the milestones: 4.5, 4.6 Sep 5, 2025
@Repiteo Repiteo added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Sep 5, 2025
@mihe mihe force-pushed the logger-docs-note branch from 92a930f to 3b3da69 Compare October 12, 2025 13:39
@mihe mihe requested a review from a team October 12, 2025 13:39
Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@mihe mihe force-pushed the logger-docs-note branch from 3b3da69 to 3868e7e Compare October 12, 2025 20:04
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Repiteo Repiteo merged commit fe4cc92 into godotengine:master Oct 23, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 23, 2025

Thanks!

@mihe mihe deleted the logger-docs-note branch October 23, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release documentation enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Logger class' _log_message() method broken in 4.5 beta.4

6 participants