Fix 3D CSG not reacting to child node order changes #100340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 3D CSG not reacting to child node order changes.
fire
approved these changes
Dec 13, 2024
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 3D CSG not reacting to child node order changes.
While working on the 2D CSG #99911 I noticed that when I just moved csg child nodes up and down in the SceneTree order it would not update the CSG shapes.
This was because the
_notifcation()code was missing theNOTIFICATION_CHILD_ORDER_CHANGEDto set the dirty flags. The csg nodes only reacted to theNOTIFICATION_PARENTEDandNOTIFICATION_UNPARENTEDnotifcations. Without a full (re)parent event it would not update. The child order is critical for the result as the CSG operations are applied in child order.Fast forward knowing that I had copied that entire update and notification code from the 3D version here is the same fix for 3D.