Skip to content

Conversation

@raulsntos
Copy link
Member

@raulsntos raulsntos commented Apr 19, 2024

It's that time of the year again. This documents all the breaking changes in 4.3, like we did for 4.2 (#8488), and 4.1 (#7611).

Area maintainers should review the changes listed for their area. Also feel free to suggest any addition that I might have missed or make follow-up PRs.

Updated as of commit godotengine/godot@26d1577

Bugsquad edit: Preview: https://github.com/raulsntos/godot-docs/blob/breaking_changes_4.3/tutorials/migrating/upgrading_to_godot_4.3.rst

@raulsntos raulsntos added enhancement content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Apr 19, 2024
@raulsntos raulsntos added this to the 4.3 milestone Apr 19, 2024
@raulsntos raulsntos force-pushed the breaking_changes_4.3 branch 4 times, most recently from 9004071 to ac20c42 Compare May 22, 2024 14:55
@raulsntos raulsntos force-pushed the breaking_changes_4.3 branch from ac20c42 to b0f4fa8 Compare May 27, 2024 19:25
@raulsntos raulsntos force-pushed the breaking_changes_4.3 branch from b0f4fa8 to 82a6107 Compare July 9, 2024 16:12
@raulsntos
Copy link
Member Author

raulsntos commented Jul 9, 2024

I have updated the list to commit godotengine/godot@26d1577.

I would appreciate a review of the behavior changes from the respective area maintainers. I'm not involved in these areas and I likely didn't get it right.

Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Android updates look good.

@groud
Copy link
Member

groud commented Jul 10, 2024

The TileMap changes look good to me.

@skyace65
Copy link
Contributor

@raulsntos is this ready for review or do more changes need to be made?

@raulsntos raulsntos force-pushed the breaking_changes_4.3 branch from 82a6107 to 2a8cdbb Compare July 22, 2024 01:19
@raulsntos
Copy link
Member Author

raulsntos commented Jul 22, 2024

I've addressed the feedback from the previous reviews, and updated the list of breaking changes after godotengine/godot#94291.

I'd still like the behavior changes to be reviewed by the respective area maintainers, mainly the rendering area. But I can probably take it out of draft now.

@raulsntos raulsntos marked this pull request as ready for review July 22, 2024 01:25
Copy link
Member

@timothyqiu timothyqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PackedByteArray changes look good.

@raulsntos raulsntos force-pushed the breaking_changes_4.3 branch from 2a8cdbb to 44e89b2 Compare July 22, 2024 02:55
Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Animation

Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor issue.

@raulsntos raulsntos force-pushed the breaking_changes_4.3 branch from 44e89b2 to 6571806 Compare July 23, 2024 02:05
@raulsntos raulsntos force-pushed the breaking_changes_4.3 branch from 6571806 to 305eca6 Compare July 26, 2024 15:33
@skyace65
Copy link
Contributor

@raulsntos I see you just pushed some more changes today. Do you still need to do work on this or is it good to merge?

@raulsntos
Copy link
Member Author

Yes, the latest changes were suggested in the development chat. Further changes can be made as follow-up PRs.

@skyace65 skyace65 merged commit afbece3 into godotengine:master Jul 28, 2024
@skyace65
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants