Add instructions for updating a GDExtension for Godot 4.1 #7656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
enhancement
area:manual
paddy-exe
approved these changes
Jul 16, 2023
Contributor
paddy-exe
left a comment
paddy-exe
left a comment
There was a problem hiding this comment.
From looking over it, this looks great. Not sure if we need to also mention that there will be a new branch of godot-cpp named 4.1 to checkout?
dsnopek
force-pushed
the
updating_gdextension_godot_4_1
branch
from
a5ad1b6 to
6617088
Compare
Contributor
Author
|
Thanks! I've added a small note regarding the |
paddy-exe
approved these changes
Jul 17, 2023
mhilbrunner
approved these changes
Jul 18, 2023
Member
|
Thanks! Merged. |
mhilbrunner
added a commit
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on #7611 to add some more detailed instructions for updating a GDExtension for Godot 4.1.
I'm not entirely sure I'm showing the C++ changes in the most understandable way. With the incomplete syntax highlighting it's really hard to immediately see difference between the two code snippets. If anyone has any suggestions on how to make it clearer, please let me know!