Remove lifetime from PassiveGd
#1312
Merged
+102
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lifetime's intention was to express the "outlives" relation from `&self` to
`PassiveGd<'_, T>`. This worked, however it also introduced a breaking change in the
`BaseRef` + `BaseMut` guards. Code such as the following now caused borrow errors:
for i in 0..self.base().get_child_count() {
self.base_mut().rotate(10.0);
}
This isn't very intuitive, nor particularly helpful for soundness. This reverts the
`PartialGd<'gd, T>` to `PartialGd<T>` with unsafe constructors. In practice, quite
some unsafety was still needed anyway (e.g. `BaseMut` needed an unsafe `'static`
intermediate reference).
Bromeon
force-pushed
the
bugfix/base-borrows
branch
from
c465441 to
4a5dfd7
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression introduced by #1302, resulting in too strict borrow checks.
The lifetime's intention was to express the "outlives" relation from
&selftoPassiveGd<'_, T>. This worked, however it also introduced a breaking change in theBaseRef+BaseMutguards. Code such as the following now caused borrow errors:This isn't very intuitive, nor particularly helpful for soundness. This PR reverts the
PartialGd<'gd, T>toPartialGd<T>with unsafe constructors. In practice, quite some unsafety was still needed anyway (e.g.BaseMutneeded an unsafe'staticintermediate reference).