Skip to content

feat: upgrade config-godaddy parser option #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2022
Merged

feat: upgrade config-godaddy parser option #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eslint-config-godaddy/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = {
plugins: ['mocha', 'json'],
extends: ['eslint:recommended'],
parserOptions: {
ecmaVersion: 9,
ecmaVersion: 13,
Copy link
Contributor

@agerard-godaddy agerard-godaddy Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this was pretty far behind.

Copy link
Contributor

@agerard-godaddy agerard-godaddy Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, before we merge... is ecmaVersion 13 available on eslint v7? We may need to bump the peerDependencies and as a result require a new major release of this config

Copy link
Contributor

@rmarkins-godaddy rmarkins-godaddy Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agerard-godaddy @mmason2-godaddy just as a follow up I am going to bump the peerDependency to v8 prior to release of a new major version

sourceType: 'module',
ecmaFeatures: {
globalReturn: true
Expand Down