use default port if port is missing in dsn (#668) #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
reviewed
Sep 19, 2017
dsn.go
Outdated
|
|
||
| func ensureHavePort(addr string) string { | ||
| s := strings.Split(addr, ":") | ||
| if len(s) == 1 { |
There was a problem hiding this comment.
strings.ContainsRune(addr, ':')
There was a problem hiding this comment.
Or use SplitHostPort to support IPv6
There was a problem hiding this comment.
if _, _, err := net.SplitHostPort(addr); err != nil {
addr = net.JoinHostPort(addr, "3306")
}
return addr
There was a problem hiding this comment.
@methane , thank you, good approach.
methane
approved these changes
Sep 19, 2017
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in case if connection addr does not have port, set default port. (3306)
Checklist