Move more webhook codes from models to webhook module #8802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
6543
approved these changes
Nov 3, 2019
GiteaBot
added
the
lgtm/need 1
6543
requested changes
Nov 3, 2019
Member
6543
left a comment
6543
left a comment
There was a problem hiding this comment.
"models/webhook_test.go:31:16: w.GetSlackHook undefined (type *Webhook has no field or method GetSlackHook)"
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #8802 +/- ##
==========================================
- Coverage 41.25% 41.22% -0.03%
==========================================
Files 542 542
Lines 69708 69708
==========================================
- Hits 28758 28738 -20
- Misses 37269 37289 +20
Partials 3681 3681
Continue to review full report at Codecov.
|
6543
approved these changes
Nov 3, 2019
guillep2k
approved these changes
Nov 3, 2019
GiteaBot
added
lgtm/done
Contributor
|
make lg-tm work |
blueworrybear
added a commit
to blueworrybear/gitea
that referenced
this pull request
Nov 14, 2019
…ation/webhook due to go-gitea#8802 refactoring
techknowlogick
pushed a commit
that referenced
this pull request
Nov 22, 2019
* 'update' * Send push tag event when release created * send tag create event while release created in UI * update to go v1.13 * fix gofmt error * update #8671 move release tag created hook to modules/notification/webhook due to #8802 refactoring * use NotifyCreateRef and NotifyPushCommits instead of NotifyNewReleaseTag * move tag notification to correct place
lafriks
pushed a commit
to lafriks-fork/gitea
that referenced
this pull request
Jan 13, 2020
…#8671) * 'update' * Send push tag event when release created * send tag create event while release created in UI * update to go v1.13 * fix gofmt error * update go-gitea#8671 move release tag created hook to modules/notification/webhook due to go-gitea#8802 refactoring * use NotifyCreateRef and NotifyPushCommits instead of NotifyNewReleaseTag * move tag notification to correct place
zeripath
pushed a commit
that referenced
this pull request
Jan 13, 2020
…9702) * 'update' * Send push tag event when release created * send tag create event while release created in UI * update to go v1.13 * fix gofmt error * update #8671 move release tag created hook to modules/notification/webhook due to #8802 refactoring * use NotifyCreateRef and NotifyPushCommits instead of NotifyNewReleaseTag * move tag notification to correct place Co-authored-by: Benno <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.