Skip to content

Delete releases attachments if release is deleted #6068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 22, 2019
Merged

Delete releases attachments if release is deleted #6068

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4ac0923
delete attachments from the database and file system
adelowo Feb 12, 2019
c632e48
add migration
adelowo Feb 14, 2019
7b3510f
fix import statements
adelowo May 14, 2019
7b8c816
fix package name
adelowo May 14, 2019
797f275
Merge remote-tracking branch 'origin' into delete_releases_attachment…
adelowo Sep 17, 2019
c1908f4
remove conditional should in case the confi has been changed and the …
adelowo Sep 17, 2019
c228842
Merge branch 'master' of github.com:go-gitea/gitea into delete_releas…
adelowo Sep 18, 2019
7832a9a
simplify deletion of attachments in DB
adelowo Sep 18, 2019
9355bbc
fix CI build
adelowo Sep 18, 2019
7063bf3
fix review
adelowo Sep 20, 2019
cf713a4
fix merge conflicts
adelowo Sep 20, 2019
c59b9d6
add copyright in the proper place
adelowo Sep 20, 2019
f018f87
Merge remote-tracking branch 'origin' into delete_releases_attachment…
adelowo Sep 20, 2019
e094f75
fix review
adelowo Sep 20, 2019
d26a10c
Merge branch 'master' into delete_releases_attachments_if_release_is_…
adelowo Sep 20, 2019
889dff6
Merge branch 'master' into delete_releases_attachments_if_release_is_…
adelowo Sep 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions models/release.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,11 +381,8 @@ func DeleteReleaseByID(id int64, doer *User, delTag bool) error {
uuids = append(uuids, attachment.UUID)
}

if _, err := x.In("uuid", uuids).Delete(new(Attachment)); err != nil {
return err
}

return nil
_, err := x.Delete(&Attachment{ReleaseID: id})
return err
}

// SyncReleasesWithTags synchronizes release table with repository tags
Expand Down